Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv
Date	2015-10-21 15:30 +0200
Message-ID	<qm1CO-4fn-5@gated-at.bofh.it> (permalink)
References	<qlLHH-65j-3@gated-at.bofh.it> <qlLHI-65j-23@gated-at.bofh.it> <qlX6a-5ZV-3@gated-at.bofh.it> <qlXSx-7bk-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Wed, Oct 21, 2015 at 11:25:25AM +0200, Ingo Molnar escreveu:
> * Peter Zijlstra <peterz@infradead.org> wrote:
> > On Tue, Oct 20, 2015 at 05:25:07PM -0300, Arnaldo Carvalho de Melo wrote:
> > > From: Andi Kleen <ak@linux.intel.com>

> > > Add a missing field to the perf_event_attr debug output.

> > > +++ b/tools/perf/util/evsel.c
> > > @@ -1229,6 +1229,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
> > >  	PRINT_ATTRf(config, p_hex);
> > >  	PRINT_ATTRn("{ sample_period, sample_freq }", sample_period, p_unsigned);
> > >  	PRINT_ATTRf(sample_type, p_sample_type);
> > > +	PRINT_ATTRf(branch_sample_type, p_unsigned);
> > >  	PRINT_ATTRf(read_format, p_read_format);

> > As said in the original thread, this is the wrong place, it should be
> > between config2 and sample_regs_user.
 
> Ok, I've unpulled these updates, since I haven't pushed these bits out yet.

I'll fix this as pointed out by Peter and resubmit.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[GIT PULL 0/4] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-20 22:30 +0200
  [PATCH 4/4] perf evsel: Print branch filter state with -vv Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-20 22:30 +0200
    Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv Peter Zijlstra <peterz@infradead.org> - 2015-10-21 10:40 +0200
      Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv Ingo Molnar <mingo@kernel.org> - 2015-10-21 11:30 +0200
        Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-21 15:30 +0200
      Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-21 20:10 +0200
        Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv Peter Zijlstra <peterz@infradead.org> - 2015-10-21 21:30 +0200
  [PATCH 2/4] tools lib traceevent: update KVM plugin Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-20 22:30 +0200
  Re: [GIT PULL 0/4] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2015-10-21 10:20 +0200

csiph-web