Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1251093
| From | Sowmini Varadhan <sowmini.varadhan@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA |
| Date | 2015-10-19 23:30 +0200 |
| Message-ID | <qlqae-8it-43@gated-at.bofh.it> (permalink) |
| References | <qlqad-8it-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On sparc, deleting established SAs (e.g., by restarting ipsec at the peer) results in unaligned access messages via xfrm_del_sa -> km_state_notify -> xfrm_send_state_notify(). Use an aligned pointer to xfrm_usersa_info for this case. Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> --- net/xfrm/xfrm_user.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index a8de9e3..158ef4a 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -2659,7 +2659,7 @@ static int xfrm_notify_sa(struct xfrm_state *x, const struct km_event *c) if (attr == NULL) goto out_free_skb; - p = nla_data(attr); + p = PTR_ALIGN(nla_data(attr), __alignof__(*p)); } err = copy_to_user_state_extra(x, p, skb); if (err) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] xfrm/crypto: unaligned access fixes Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-19 23:30 +0200
[PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-19 23:30 +0200
Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA Steffen Klassert <steffen.klassert@secunet.com> - 2015-10-21 09:00 +0200
Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-21 13:00 +0200
Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-21 14:40 +0200
Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA David Miller <davem@davemloft.net> - 2015-10-21 15:10 +0200
Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-21 15:20 +0200
Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA David Miller <davem@davemloft.net> - 2015-10-21 15:10 +0200
Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA David Miller <davem@davemloft.net> - 2015-10-21 15:00 +0200
csiph-web