Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1251039

Re: [PATCH 1/2] serial: support register interface with 16-bit stride for console

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Peter Hurley <peter@hurleysoftware.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] serial: support register interface with 16-bit stride for console
Date Mon, 19 Oct 2015 22:00:01 +0200
Message-ID <qloL7-64d-5@gated-at.bofh.it> (permalink)
References <qlbuy-3xU-7@gated-at.bofh.it> <qlbux-3xU-5@gated-at.bofh.it>
X-Original-To Masahiro Yamada <yamada.masahiro@socionext.com>, linux-serial@vger.kernel.org
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=GwxyrxPJsqdA5GkxF+TqMW9XjR+1ju1uwD7/1gcCTzg=; b=IYjg/tuRKZcT34+X5qb1zHTaHiuRjZB5KFrYVqgx5D5Uxqye5V2ewKL5oxzDJt5L5Z 8iyaPZ8+VTxXCLQiGhYvPJQTawl/RV2TsqG5JKiWWI7R4sXA/JKphuKdQwnVq3zHQ1R5 TufnvM6NVn6+vUmjEL40DK4EeAZd8xd4HQiLafFn9afmH0cQ00YVArImZ2rUmZ4lLbiR eEAf8ZyHrtMwI+0snngeqD5KcyjEE7cugUZ5c/JdSEREO3SFQ90ojOd3UKbbSZHNZIs8 Ojkahz62D42c384qx2Fv1p7dHTEPL/qMIqGiTX5PPg8lOVsvB2wPX/IPARiXfTERrNss K5FA==
X-Gm-Message-State ALoCoQnG25PkrXUPJUppjkJRiZ7M6tHrcYYGK5bjKFl4NLhCRC4W0HFpmj+aBePu9qXhg0BcpjXC
X-Received by 10.55.209.147 with SMTP id o19mr38000145qkl.61.1445284208438; Mon, 19 Oct 2015 12:50:08 -0700 (PDT)
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 63
Organization linux.* mail to news gateway
X-Original-Cc Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Vineet Gupta <Vineet.Gupta1@synopsys.com>, Kevin Cernekee <cernekee@gmail.com>, Jiri Slaby <jslaby@suse.com>, Rob Herring <robh@kernel.org>, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org, Wang Long <long.wanglong@huawei.com>, Noam Camus <noamc@ezchip.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Eddie Huang <eddie.huang@mediatek.com>
X-Original-Date Mon, 19 Oct 2015 15:50:04 -0400
X-Original-Message-ID <5625496C.90507@hurleysoftware.com>
X-Original-References <1445233224-23150-1-git-send-email-yamada.masahiro@socionext.com> <1445233224-23150-2-git-send-email-yamada.masahiro@socionext.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1251039

Show key headers only | View raw


On 10/19/2015 01:40 AM, Masahiro Yamada wrote:
> Currently, 8-bit (MMIO) and 32-bit (MMIO32) strides are supported for
> the 8250 console, but 16-bit (MMIO16) stride is not.  The 8250 UART
> device on my board has 16-bit stride (reg-shift = <1>) and I am eager
> to use earlycon with it.
> 
> Refer to arch/arm/boot/dts/uniphier-support-card.dtsi:
> 
>         serialsc: uart@000b0000 {
>                 compatible = "ns16550a";
>                 reg = <0x000b0000 0x20>;
>                 clock-frequency = <12288000>;
>                 reg-shift = <1>;
>         };
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  Documentation/kernel-parameters.txt  |  9 +++++----
>  drivers/tty/serial/8250/8250_early.c |  5 +++++
>  drivers/tty/serial/8250/8250_port.c  | 20 ++++++++++++++++++++
>  drivers/tty/serial/earlycon.c        | 15 +++++++++++----
>  drivers/tty/serial/serial_core.c     |  9 +++++++--
>  include/linux/serial_core.h          |  1 +
>  include/uapi/linux/serial.h          |  9 +++++----
>  7 files changed, 54 insertions(+), 14 deletions(-)
> 

[...]

> diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h
> index 25331f9..1d20d9c 100644
> --- a/include/uapi/linux/serial.h
> +++ b/include/uapi/linux/serial.h
> @@ -65,10 +65,11 @@ struct serial_struct {
>  #define SERIAL_IO_PORT	0
>  #define SERIAL_IO_HUB6	1
>  #define SERIAL_IO_MEM	2
> -#define SERIAL_IO_MEM32	  3
> -#define SERIAL_IO_AU	  4
> -#define SERIAL_IO_TSI	  5
> -#define SERIAL_IO_MEM32BE 6
> +#define SERIAL_IO_MEM16	3
> +#define SERIAL_IO_MEM32	  4
> +#define SERIAL_IO_AU	  5
> +#define SERIAL_IO_TSI	  6
> +#define SERIAL_IO_MEM32BE 7

The existing values cannot be re-defined since they're userspace visible.

Regards,
Peter Hurley


>  #define UART_CLEAR_FIFO		0x01
>  #define UART_USE_FIFO		0x02
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] serial: support register interface with 16-bit stride for console Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-19 07:50 +0200
  Re: [PATCH 1/2] serial: support register interface with 16-bit stride  for console Peter Hurley <peter@hurleysoftware.com> - 2015-10-19 22:00 +0200
    Re: [PATCH 1/2] serial: support register interface with 16-bit stride  for console Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-20 05:40 +0200

csiph-web