Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform.

From	Josh Cartwright <joshc@ni.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform.
Date	2015-10-19 20:30 +0200
Message-ID	<qlnm1-46a-3@gated-at.bofh.it> (permalink)
References	<qklZ0-3t5-15@gated-at.bofh.it> <qklZ0-3t5-25@gated-at.bofh.it> <ql0ps-3ZY-5@gated-at.bofh.it> <qlnm1-46a-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 19, 2015 at 04:09:09PM +0200, Michal Simek wrote:
> On 10/18/2015 07:53 PM, Josh Cartwright wrote:
> > On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote:
[..]
> >> @@ -294,6 +294,11 @@
> >>  		devcfg: devcfg@f8007000 {
> >>  			compatible = "xlnx,zynq-devcfg-1.0";
> >>  			reg = <0xf8007000 0x100>;
> >> +			interrupt-parent = <&intc>;
> > 
> > You shouldn't need interrupt-parent here.  In fact, I suspect it can be
> > removed from all sibling nodes as well.
> 
> Correct. But I tend to do it vice-versa. To remove it from amba node and
> keep it in every IP here. The reason is simple to let everybody know
> that setting up right interrupt controller is something what they have
> to care. If you have more interrupt controllers in the system it can be
> messy.

If you like that, then you'd like the interrupt-extended properly even
better (I think).

> But again. Please remove this patch from this series. This will go to
> mainline through arm-soc but 1/3 and 3/3 will go through Greg. That's
> why please do not include it here.

Not all of the patches in a series need to go through the same
maintainer...splitting them up is common.  It's nice seeing related
things out on the list together.  (Especially when there is a dependency
at some level).

  Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000  platform. Josh Cartwright <joshc@ni.com> - 2015-10-18 20:00 +0200
  Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000  platform. Josh Cartwright <joshc@ni.com> - 2015-10-19 20:30 +0200

csiph-web