Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1250980

Re: [PATCH v3] arm64: Synchronise dump_backtrace() with perf callchain

From Catalin Marinas <catalin.marinas@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3] arm64: Synchronise dump_backtrace() with perf callchain
Date 2015-10-19 20:10 +0200
Message-ID <qln2G-3Iv-3@gated-at.bofh.it> (permalink)
References <qkAEF-8uY-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Oct 17, 2015 at 02:28:11PM +0000, Jungseok Lee wrote:
> Note that this patch does not cover a case where MMU is disabled. The
> last stack frame of swapper, for example, has PC in a form of physical
> address. Unfortunately, a simple conversion using phys_to_virt() cannot
> cover all scenarios since PC is retrieved from LR - 4, not LR. It is
> a big tradeoff to change both head.S and unwind_frame() for only a few
> of symbols in *.S. Thus, this hunk does not take care of the case.

That's fine, I think we can cope with a physical address as the last
entry in the trace.

Patch queued for 4.4. Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v3] arm64: Synchronise dump_backtrace() with perf  callchain Catalin Marinas <catalin.marinas@arm.com> - 2015-10-19 20:10 +0200

csiph-web