Re: [PATCH v1 3/6] blk-mq: check bio_mergeable() early before merging

From	Jeff Moyer <jmoyer@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 3/6] blk-mq: check bio_mergeable() early before merging
Date	2015-10-19 17:20 +0200
Message-ID	<qlkoa-8eL-15@gated-at.bofh.it> (permalink)
References	<qkC3L-21m-3@gated-at.bofh.it> <qkC3M-21m-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Ming Lei <ming.lei@canonical.com> writes:

> It isn't necessary to try to merge the bio which is marked
> as NOMERGE.
>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

> ---
>  block/blk-mq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 546b3b8..d55d022 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1140,7 +1140,7 @@ static inline bool blk_mq_merge_queue_io(struct blk_mq_hw_ctx *hctx,
>  					 struct blk_mq_ctx *ctx,
>  					 struct request *rq, struct bio *bio)
>  {
> -	if (!hctx_allow_merges(hctx)) {
> +	if (!hctx_allow_merges(hctx) || !bio_mergeable(bio)) {
>  		blk_mq_bio_to_request(rq, bio);
>  		spin_lock(&ctx->lock);
>  insert_rq:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v1 3/6] blk-mq: check bio_mergeable() early before merging Jeff Moyer <jmoyer@redhat.com> - 2015-10-19 17:20 +0200

csiph-web