Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework

From	John Garry <john.garry@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework
Date	2015-10-19 16:20 +0200
Message-ID	<qljs6-6P9-13@gated-at.bofh.it> (permalink)
References	<qiN3k-2LY-27@gated-at.bofh.it> <qkcM2-6LS-15@gated-at.bofh.it> <qkdoJ-7Ml-3@gated-at.bofh.it> <qkdoJ-7Ml-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16/10/2015 14:36, Arnd Bergmann wrote:
> On Friday 16 October 2015 14:29:55 John Garry wrote:
>>
>> It could be considered.
>>
>> A potential issue I see is with hisi_sas_control_phy() for
>> PHY_FUNC_HARD_RESET: this allocates a hisi_sas_wq struct and processes
>> the reset in the queue work. When we re-enable the phy for the reset,
>> the phyup irq will want to use the same hisi_sas_wq struct which may be
>> in use.
>>
>> hisi_sas_control_phy() is added in 23/35.
>
> I'd have to review more closely, but I think that's fine, as this
> is how most work queues are used: you can queue the same function
> multiple times, and it's guaranteed to run at least once after
> the last queue, so if you queue it while it's already running,
> it will be called again, otherwise it won't.
>
> 	Arnd
>
> .
>
In the scenario I described the issue is not that the second call to 
queue the work function is lost. The problem is that when we setup the 
second call we may overwrite elements of the phy's hisi_sas_wq struct 
which may be still being referenced in the work function for the first call.

Regards,
John

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS  framework John Garry <john.garry@huawei.com> - 2015-10-19 16:20 +0200
  Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework Arnd Bergmann <arnd@arndb.de> - 2015-10-19 16:30 +0200
    Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS  framework John Garry <john.garry@huawei.com> - 2015-10-19 17:00 +0200
      Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework Arnd Bergmann <arnd@arndb.de> - 2015-10-20 10:50 +0200
        Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS  framework John Garry <john.garry@huawei.com> - 2015-10-20 11:30 +0200

csiph-web