Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250752

Re: [PATCH] fault-inject: fix inverted interval/probability values in printk

Show all headers | View raw

2015-10-17 17:51 GMT+09:00 Florian Westphal <fw@strlen.de>:
> interval displays the probability and vice versa.
>
> Fixes: 6adc4a22f20bb ("fault-inject: add ratelimit option")
> Signed-off-by: Florian Westphal <fw@strlen.de>

Looks good to me.

Acked-by: Akinobu Mita <akinobu.mita@gmail.com>

Andrew, could you consider to merge this patch to your tree?

> ---
>  lib/fault-inject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index f1cdeb0..6a823a5 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
>                 printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
>                        "name %pd, interval %lu, probability %lu, "
>                        "space %d, times %d\n", attr->dname,
> -                      attr->probability, attr->interval,
> +                      attr->interval, attr->probability,
>                        atomic_read(&attr->space),
>                        atomic_read(&attr->times));
>                 if (attr->verbose > 1)
> --
> 2.0.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] fault-inject: fix inverted interval/probability values in printk Akinobu Mita <akinobu.mita@gmail.com> - 2015-10-19 16:30 +0200

csiph-web