Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250673

Re: [PATCH 2/4] vfio: platform: reset: calxedaxgmac: add reset function registration

Show all headers | View raw

Hi Arnd,
On 10/19/2015 03:04 PM, Arnd Bergmann wrote:
> On Sunday 18 October 2015 18:00:13 Eric Auger wrote:
>> diff --git a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
>> index 619dc7d..4f76b17 100644
>> --- a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
>> +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
>> @@ -29,8 +29,7 @@
>>  #define DRIVER_VERSION  "0.1"
>>  #define DRIVER_AUTHOR   "Eric Auger <eric.auger@linaro.org>"
>>  #define DRIVER_DESC     "Reset support for Calxeda xgmac vfio platform device"
>> -
>> -#define CALXEDAXGMAC_COMPAT "calxeda,hb-xgmac"
>> +#define COMPAT		"calxeda,hb-xgmac"
> 
> Why the rename?
This define was not used. Since the code is meant to be duplicated from
one reset module to the other I thought it did not bring any have a
specialized name
> 
>>  /* XGMAC Register definitions */
>>  #define XGMAC_CONTROL           0x00000000      /* MAC Configuration */
>> @@ -80,6 +79,43 @@ int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev)
>>  }
>>  EXPORT_SYMBOL_GPL(vfio_platform_calxedaxgmac_reset);
>>  
>> +static int __init vfio_platform_calxedaxgmac_init(void)
>> +{
>> +	int (*register_reset)(struct module *, char*,
>> +				vfio_platform_reset_fn_t);
>> +	int ret;
>> +
>> +	register_reset = symbol_get(vfio_platform_register_reset);
>> +	if (!register_reset)
>> +		return -EINVAL;
> 
> I don't understand what you do the symbol_get() here for.
> Why not just call that function directly
the function is implemented in a separate module. This is just to make
sure the vfio-platform module is loaded, in case the end-user attempts
to load the reset module without having this latter loaded.
> 
>> +	ret = register_reset(THIS_MODULE, COMPAT,
>> +	vfio_platform_calxedaxgmac_reset);
> 
> This is whitespace damaged, the second line needs to be indented
> to the opening braces.
ok
> 
> I would also suggest defining register_reset as a macro that
> implicitly passes the THIS_MODULE argument, as other subsystems
> do.
ok

Thanks

Best Regards

Eric
> 
> 	Arnd
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] VFIO platform reset module rework Eric Auger <eric.auger@linaro.org> - 2015-10-18 18:10 +0200
  [PATCH 4/4] vfio: platform: use list of registered reset function Eric Auger <eric.auger@linaro.org> - 2015-10-18 18:10 +0200
  [PATCH 3/4] vfio: platform: add compat in vfio_platform_device Eric Auger <eric.auger@linaro.org> - 2015-10-18 18:10 +0200
  [PATCH 1/4] vfio: platform: add capability to register a reset function Eric Auger <eric.auger@linaro.org> - 2015-10-18 18:10 +0200
    Re: [PATCH 1/4] vfio: platform: add capability to register a reset function Arnd Bergmann <arnd@arndb.de> - 2015-10-19 15:10 +0200
    Re: [PATCH 1/4] vfio: platform: add capability to register a reset  function Alex Williamson <alex.williamson@redhat.com> - 2015-10-19 21:50 +0200
      Re: [PATCH 1/4] vfio: platform: add capability to register a reset  function Eric Auger <eric.auger@linaro.org> - 2015-10-20 19:50 +0200
  [PATCH 2/4] vfio: platform: reset: calxedaxgmac: add reset function registration Eric Auger <eric.auger@linaro.org> - 2015-10-18 18:10 +0200
    Re: [PATCH 2/4] vfio: platform: reset: calxedaxgmac: add reset function registration Arnd Bergmann <arnd@arndb.de> - 2015-10-19 15:10 +0200
      Re: [PATCH 2/4] vfio: platform: reset: calxedaxgmac: add reset  function registration Eric Auger <eric.auger@linaro.org> - 2015-10-19 15:20 +0200
        Re: [PATCH 2/4] vfio: platform: reset: calxedaxgmac: add reset function registration Arnd Bergmann <arnd@arndb.de> - 2015-10-19 15:30 +0200
          Re: [PATCH 2/4] vfio: platform: reset: calxedaxgmac: add reset  function registration Eric Auger <eric.auger@linaro.org> - 2015-10-19 15:40 +0200
  Re: [PATCH 0/4] VFIO platform reset module rework Arnd Bergmann <arnd@arndb.de> - 2015-10-19 15:10 +0200

csiph-web