Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode
Date	Mon, 19 Oct 2015 11:20:01 +0200
Message-ID	<qleLL-8ro-7@gated-at.bofh.it> (permalink)
References	<qkotP-7aW-1@gated-at.bofh.it> <qkwrn-21I-1@gated-at.bofh.it> <qldwm-6s2-17@gated-at.bofh.it>
X-Original-To	Stephane Eranian <eranian@google.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2012-12-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, "mingo@elte.hu" <mingo@elte.hu>, "ak@linux.intel.com" <ak@linux.intel.com>, Eric Dumazet <edumazet@google.com>, Arnaldo Carvalho de Melo <acme@redhat.com>
X-Original-Date	Mon, 19 Oct 2015 11:12:25 +0200
X-Original-Message-ID	<20151019091225.GH3816@twins.programming.kicks-ass.net>
X-Original-References	<20151017012811.GA18581@thinkpad> <20151017095651.GE3816@twins.programming.kicks-ass.net> <CABPqkBS88_p7DZwVPKgEz0HSqth5zzhFjpRzeF8O9HhYByEJmg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1250487

Show key headers only | View raw

On Mon, Oct 19, 2015 at 12:58:47AM -0700, Stephane Eranian wrote:
> Peter,
> 
> On Sat, Oct 17, 2015 at 2:56 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Sat, Oct 17, 2015 at 03:28:11AM +0200, Stephane Eranian wrote:
> > >
> > > This patch eliminates all known RCU violations detected
> > > by the RCU  checker (PROVE_RCU). The impact code paths
> > > were all related to cgroup mode monitoring and involved
> > > access a task's cgrp.
> >
> > But were they right? This patch provides no clues.
> >
> I am assuming that is the checker detects something suspicious there is likely
> a problem.
> 
> Take for instance:
>  perf_cgroup_sched_out()->perf_cgroup_from_task() ->task_subsys_state()
> 
> That one fires the checker. I think because we are accessing the css
> state without
> protection.
> 
> The other places are similar.

But perf_cgroup_attach()->perf_cgroup_switch() takes ctx->lock().

Therefore; if you hold ctx->lock, the cgroup is pinned.

And the above sequence very much holds ctx->lock.

Right?

So it looks to me that we should teach perf_cgroup_from_task() about
ctx->lock or something.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] perf/core: fix RCU issues with cgroup monitoring mode Stephane Eranian <eranian@google.com> - 2015-10-17 03:30 +0200
  Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode Peter Zijlstra <peterz@infradead.org> - 2015-10-17 12:00 +0200
    Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode Stephane Eranian <eranian@google.com> - 2015-10-19 10:00 +0200
      Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode Peter Zijlstra <peterz@infradead.org> - 2015-10-19 11:20 +0200
        Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode Stephane Eranian <eranian@google.com> - 2015-10-26 20:30 +0100
          Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode Peter Zijlstra <peterz@infradead.org> - 2015-10-26 21:30 +0100
  Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode Peter Zijlstra <peterz@infradead.org> - 2015-10-17 12:10 +0200

csiph-web