Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ numbers

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Luis Henriques <luis.henriques@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ numbers
Date	Mon, 19 Oct 2015 10:40:01 +0200
Message-ID	<qle93-7rs-7@gated-at.bofh.it> (permalink)
References	<qeml5-1mP-5@gated-at.bofh.it> <qemO6-2bO-7@gated-at.bofh.it> <qjHoR-2nM-9@gated-at.bofh.it> <qjKd4-6vf-19@gated-at.bofh.it> <qjMHU-1Qp-23@gated-at.bofh.it>
X-Original-To	Benjamin Cama <benoar@dolka.fr>
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-1
Content-Disposition	inline
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	Gregory CLEMENT <gregory.clement@free-electrons.com>, Ben Hutchings <ben@decadent.org.uk>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com
X-Original-Date	Mon, 19 Oct 2015 09:39:13 +0100
X-Original-Message-ID	<20151019083913.GA3424@ares>
X-Original-References	<1443606681-7124-1-git-send-email-luis.henriques@canonical.com> <1443606681-7124-54-git-send-email-luis.henriques@canonical.com> <1444879386.31451.42.camel@decadent.org.uk> <87vba83b3g.fsf@free-electrons.com> <14a78331a910eca4ab25bf718a89bee4@dolka.fr>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1250450

Show key headers only | View raw

On Thu, Oct 15, 2015 at 11:03:19AM +0200, Benjamin Cama wrote:
> Hi everyone,
> 
> Le 2015-10-15 08:22, Gregory CLEMENT a écrit :
> > On jeu., oct. 15 2015, Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> >>On Wed, 2015-09-30 at 10:50 +0100, Luis Henriques wrote:
> >>>3.16.7-ckt18 -stable review patch.  If anyone has any objections,
> >>>please let me know.
> >>>
> >>>------------------
> >>>
> >>>From: Benjamin Cama <benoar@dolka.fr>
> >>>
> >>>commit 5be9fc23cdb42e1d383ecc8eae8a8ff70a752708 upstream.
> >>>
> >>>Since v3.18, attempts to deliver IRQ0 are rejected, breaking orion5x.
> >>[...]
> >>
> >>But I don't think this was needed for 3.16-ckt, was it?
> >
> >Indeed it fixes a commit (a71b092a9c68 ("ARM: Convert handle_IRQ to use
> >__handle_domain_irq")) that was introduced in 3.18:
> >
> >git tag --contains a71b092a9c68 | grep "^v3\." | sort | head -1
> >v3.18
> >
> >So please Luis do not apply it on 3.16-ckt unless you already back port
> >the commit a71b092a9c68 ("ARM: Convert handle_IRQ to use
> >__handle_domain_irq") on this branch.
> 
> Indeed it is not completely needed, but to be clear it "just" shifts the
> IRQs by one, so it shouldn't do any harm either. So it is up to you. I would
> understand that you choose not to apply it to be on the safe side. BTW, it
> seems f28d7de is required by my patch, appearing in 3.14; as I don't follow
> kernel development closely, I could not assure you my patch is completly
> safe for 3.16.
>

*Sigh*
Sorry for letting this commit getting in.  I'm reverting it for the next
3.16 kernel release.  Thank you all!

Cheers,
--
Luís
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ  numbers Ben Hutchings <ben@decadent.org.uk> - 2015-10-15 05:30 +0200
  Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ numbers Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-15 08:30 +0200
    Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ  numbers Benjamin Cama <benoar@dolka.fr> - 2015-10-15 11:10 +0200
      Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ  numbers Luis Henriques <luis.henriques@canonical.com> - 2015-10-19 10:40 +0200

csiph-web