Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250431

Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

Show all headers | View raw

On Sat, Oct 17, 2015 at 1:29 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The iio dummy code was recently changed to use irq_work_queue, but
> that code is compiled into the kernel only if IRQ_WORK is set, so
> we can get a link error here:
>
> drivers/built-in.o: In function `iio_evgen_poke':
> (.text+0x208a04): undefined reference to `irq_work_queue'
>
> This changes the Kconfig file to match what other drivers do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")

Acked-by: Daniel Baluta <daniel.baluta@intel.com>

> ---
> Found on ARM randconfig tests
>
> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
> index 6d5b38d69578..9d7f0004d2d7 100644
> --- a/drivers/staging/iio/Kconfig
> +++ b/drivers/staging/iio/Kconfig
> @@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig"
>  source "drivers/staging/iio/trigger/Kconfig"
>
>  config IIO_DUMMY_EVGEN
> -       tristate
> +       tristate
> +       select IRQ_WORK
>
>  config IIO_SIMPLE_DUMMY
>         tristate "An example driver with no hardware requirements"
>
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN Arnd Bergmann <arnd@arndb.de> - 2015-10-17 00:40 +0200
  Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN Daniel Baluta <daniel.baluta@intel.com> - 2015-10-19 10:20 +0200
    Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN Jonathan Cameron <jic23@kernel.org> - 2015-10-25 13:20 +0100

csiph-web