Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1250377
| From | Marc Kleine-Budde <mkl@pengutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net, can, ti_hecc: fix a run time warn_on. |
| Date | 2015-10-19 08:40 +0200 |
| Message-ID | <qlcgW-4Ju-3@gated-at.bofh.it> (permalink) |
| References | <qlc7g-4wB-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On 10/19/2015 08:22 AM, Heiko Schocher wrote:
> This patch fixes a warning in clk_enable by calling
> clk_prepare_enable instead.
What about the corresponding clk_disable_unprepare()?
Marc
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>
> drivers/net/can/ti_hecc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
> index cf345cb..c08e8ea 100644
> --- a/drivers/net/can/ti_hecc.c
> +++ b/drivers/net/can/ti_hecc.c
> @@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
> netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll,
> HECC_DEF_NAPI_WEIGHT);
>
> - clk_enable(priv->clk);
> + clk_prepare_enable(priv->clk);
> err = register_candev(ndev);
> if (err) {
> dev_err(&pdev->dev, "register_candev() failed\n");
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net, can, ti_hecc: fix a run time warn_on. Heiko Schocher <hs@denx.de> - 2015-10-19 08:30 +0200
Re: [PATCH] net, can, ti_hecc: fix a run time warn_on. Marc Kleine-Budde <mkl@pengutronix.de> - 2015-10-19 08:40 +0200
Re: [PATCH] net, can, ti_hecc: fix a run time warn_on. Heiko Schocher <hs@denx.de> - 2015-10-19 09:00 +0200
csiph-web