Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1252566

Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on some toshiba models

Show all headers | View raw

On Tue, Oct 20, 2015 at 12:32:45AM +0100, Ben Hutchings wrote:
> On Sat, 2015-10-17 at 18:55 -0700, Greg Kroah-Hartman wrote:
> > 4.2-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Azael Avalos <coproscefalo@gmail.com>
> > 
> > commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream.
> > 
> > Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function
> > for keymap choosing") changed the *setup_keyboard function to query for
> > the Hotkey Event Type to help choose the correct keymap, but turns out
> > that here are certain Toshiba models out there not implementing this
> > feature, and thus, failing to continue the input device registration and
> > leaving such laptops without hotkey support.
> > 
> > This patch changes such check, and instead of returning an error if
> > the Hotkey Event Type is not present, we simply inform userspace about it,
> > changing the message printed from err to notice, making the function
> > responsible for registering the input device to continue.
> [...]
> 
> But then this function proceeds without events_type being initialised
> at all, with unpredictable results.  This doesn't look like a proper
>  fix.

Azael, Ben has a point. Even after later patches, dev->hotkey_event_type doesn't
have a default value, so the later check for HCI_SYSTEM_TYPE1 or
HCI_SYSTEM_TYPE2 or failure is unpredictable.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on some toshiba models Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-18 07:00 +0200
  Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on  some toshiba models Ben Hutchings <ben@decadent.org.uk> - 2015-10-20 01:40 +0200
    Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on  some toshiba models Darren Hart <dvhart@infradead.org> - 2015-10-21 10:50 +0200
      Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on  some toshiba models Azael Avalos <coproscefalo@gmail.com> - 2015-10-26 18:00 +0100

csiph-web