Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration
Date	2015-10-21 09:40 +0200
Message-ID	<qlWa5-4E2-7@gated-at.bofh.it> (permalink)
References	<qlD7s-258-11@gated-at.bofh.it> <qlD7s-258-9@gated-at.bofh.it> <qlWa5-4E2-9@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken Xue wrote:
> On Tue, 2015-10-20 at 14:17 +0300, Mika Westerberg wrote:
> > On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote:
> > > DW I2C driver tries to register a clk from id->driver_data as an
> > > alternative way besides intel lpss. But code doesn't register the
> > > clk to clkdev. So, devm_clk_get will fail during probe.
> > > 
> > > The patch can fix this issue.
> > 
> > Since you now have drivers/acpi/acpi_apd.c for AMD ACPI stuff, can you
> > create the clock there just like we do for Intel stuff?
> Sure. APD already creates the clock for AMD0010 as you expected. And the
> next patch([PATCH 2/2] i2c: designware: remove freq definition for
> "AMD0010" in acpi_device_id) is dropping the old way for getting freq.

So this patch is not necessary, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device  configuration Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-20 13:20 +0200
  Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device  configuration Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-21 09:40 +0200
    Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device  configuration Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-21 11:40 +0200
      Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device  configuration Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-21 11:50 +0200
        Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device  configuration Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-21 12:10 +0200
        Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device  configuration Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-21 12:50 +0200

csiph-web