Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'
Date	2015-10-21 09:30 +0200
Message-ID	<qlW0q-4sL-5@gated-at.bofh.it> (permalink)
References	<qglbb-2cb-3@gated-at.bofh.it> <qglbb-2cb-19@gated-at.bofh.it> <qiZHb-4hT-1@gated-at.bofh.it> <qlsvn-3a4-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Brendan,

On Mon, Oct 19, 2015 at 04:50:11PM -0700, Brendan Gregg wrote:
> On Mon, Oct 12, 2015 at 9:26 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> > On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote:
> >> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >>
> >> Which is the most common default found in other similar tools.
> >
> > I think it's more useful to change the default only when --children is
> > used.  And there's a related issue too - please see below link:
> >
> >   https://lkml.org/lkml/2014/8/14/49
> 
> --children is default for things like "perf report --stdio" and
> (implied) "perf script", so any change to --children is a change to
> default.

Hmm.. right.  It should change the default only when --children is
actually used in "perf report" or "perf top" so that "perf script" or
other commands should not be changed.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller' Brendan Gregg <brendan.d.gregg@gmail.com> - 2015-10-20 02:00 +0200
  Re: [PATCH 13/16] perf callchain: Switch default to  'graph,0.5,caller' Namhyung Kim <namhyung@kernel.org> - 2015-10-21 09:30 +0200

csiph-web