Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1252426

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

From Guenter Roeck <linux@roeck-us.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power
Date 2015-10-21 04:20 +0200
Message-ID <qlRap-5M9-9@gated-at.bofh.it> (permalink)
References <qlzwS-5dK-11@gated-at.bofh.it> <qlzwS-5dK-9@gated-at.bofh.it> <qlRap-5M9-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/20/2015 06:42 PM, Huang Rui wrote:
> On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote:
>> Hi Huang,
>>
>> [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
>>
>> url:    https://github.com/0day-ci/linux/commits/Huang-Rui/hwmon-fam15h_power-Introduce-an-accumulated-power-reporting-algorithm/20151020-110712
>> config: x86_64-randconfig-s2-10201413 (attached as .config)
>> reproduce:
>>          # save the attached .config to linux build tree
>>          make ARCH=x86_64
>>
>> All errors (new ones prefixed by >>):
>>
>>     drivers/built-in.o: In function `fam15h_power_probe':
>>>> fam15h_power.c:(.text+0x26e3a3): undefined reference to `amd_get_cores_per_cu'
>>     fam15h_power.c:(.text+0x26e41e): undefined reference to `amd_get_cores_per_cu'
>>
>
> Thanks to report this issue. :)
> The root cause is that the test config doesn't enable
> CONFIG_CPU_SUP_AMD.
>
> How about below fix:
>

Guess you don't have a choice.

Guenter

> ---
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 796569ee..603eadd 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -288,7 +288,7 @@ config SENSORS_K10TEMP
>
>   config SENSORS_FAM15H_POWER
>   	tristate "AMD Family 15h processor power"
> -	depends on X86 && PCI
> +	depends on X86 && PCI && CPU_SUP_AMD
>   	help
>   	  If you say yes here you get support for processor power
>   	  information of your AMD family 15h CPU.
>
> ---
>
> Thanks,
> Rui
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit  accumulated power kbuild test robot <lkp@intel.com> - 2015-10-20 09:30 +0200
  Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit  accumulated power Guenter Roeck <linux@roeck-us.net> - 2015-10-21 04:20 +0200
    Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit  accumulated power Guenter Roeck <linux@roeck-us.net> - 2015-10-21 05:00 +0200
      Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit  accumulated power Jean Delvare <jdelvare@suse.de> - 2015-10-21 08:10 +0200

csiph-web