Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1252062
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY |
| Date | 2015-10-20 23:40 +0200 |
| Message-ID | <qlMNt-7E9-47@gated-at.bofh.it> (permalink) |
| References | <qlMDM-7sL-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 20/10/15 14:28, Andrew F. Davis wrote: > Add support for the TI DP83848 Ethernet PHY device. > > The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant > single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting > the MII and RMII interfaces. > > Signed-off-by: Andrew F. Davis <afd@ti.com> > Signed-off-by: Dan Murphy <dmurphy@ti.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Just one comment below: [snip] > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile > index 87f079c..b748224 100644 > --- a/drivers/net/phy/Makefile > +++ b/drivers/net/phy/Makefile > @@ -24,6 +24,7 @@ obj-$(CONFIG_MDIO_BITBANG) += mdio-bitbang.o > obj-$(CONFIG_MDIO_GPIO) += mdio-gpio.o > obj-$(CONFIG_NATIONAL_PHY) += national.o > obj-$(CONFIG_DP83640_PHY) += dp83640.o > +obj-$(CONFIG_DP83848_PHY) += dp83848.o > obj-$(CONFIG_DP83867_PHY) += dp83867.o This is a pretty small PHY driver, would it make sense to look into consolidating these into e.g: dp838xx.c for instance? dp83640 is big enough to be its own driver it seems. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY "Andrew F. Davis" <afd@ti.com> - 2015-10-20 23:30 +0200
Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY Florian Fainelli <f.fainelli@gmail.com> - 2015-10-20 23:40 +0200
Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY Florian Fainelli <f.fainelli@gmail.com> - 2015-10-21 00:00 +0200
Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY "Andrew F. Davis" <afd@ti.com> - 2015-10-21 00:00 +0200
Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY Dan Murphy <dmurphy@ti.com> - 2015-10-21 02:10 +0200
Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY David Miller <davem@davemloft.net> - 2015-10-22 15:30 +0200
csiph-web