Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1251983

Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal

Show all headers | View raw

On Tue, 20 Oct 2015, Russell King - ARM Linux wrote:

> On Tue, Oct 20, 2015 at 04:08:28PM +0200, Thomas Petazzoni wrote:
> > As discussed on IRC, another simpler (code line wise) solution is to
> > simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which
> > brings us back to what set_irq_flags() was doing, without actually
> > reverting Rob's patch.
> > 
> > However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the
> > right long term solution, which is why I implemented what I believe is
> > a (hopefully) better long term solution.
> 
> However, this is rather worrying.  NOAUTOEN is supposed to avoid enabling
> the interrupt when the interrupt is claimed.
> 
> If, as a result of Rob's patch, we now have a load of IRQs which are
> marked with NOAUTOEN which weren't, that's quite a large regression -
> possibly one which hasn't been properly found (not everyone tests -rc
> kernels) and we may be better to revert Rob's patch to avoid lots of
> breakge being reported when 4.3 is released.
> 
> I think Rob's patches need another review in light of this, to determine
> how much breakage there is here, and a decision how to proceed made on
> that basis.

I'll go over them tomorrow again and decide then what to do.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Fix regression introduced by set_irq_flags() removal Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-20 15:30 +0200
  Re: [PATCH 0/5] Fix regression introduced by set_irq_flags()  removal Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-20 16:10 +0200
    Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-20 16:20 +0200
      Re: [PATCH 0/5] Fix regression introduced by set_irq_flags()  removal Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-20 16:30 +0200
      Re: [PATCH 0/5] Fix regression introduced by set_irq_flags()  removal Thomas Gleixner <tglx@linutronix.de> - 2015-10-20 21:30 +0200
        Re: [PATCH 0/5] Fix regression introduced by set_irq_flags()  removal Thomas Gleixner <tglx@linutronix.de> - 2015-10-22 10:10 +0200
    Re: [PATCH 0/5] Fix regression introduced by set_irq_flags()  removal Thomas Gleixner <tglx@linutronix.de> - 2015-10-20 21:30 +0200
      [PATCH] irqchip: irq-armada-370-xp: fix regression by clearing IRQ_NOAUTOEN Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-21 15:50 +0200
        Re: [PATCH] irqchip: irq-armada-370-xp: fix regression by clearing  IRQ_NOAUTOEN Jason Cooper <jason@lakedaemon.net> - 2015-10-21 16:50 +0200
      Re: [PATCH 0/5] Fix regression introduced by set_irq_flags()  removal Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-21 15:50 +0200
  Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Jason Cooper <jason@lakedaemon.net> - 2015-10-20 16:10 +0200

csiph-web