Re: [RFC v4 9/9] kmsg: selftests

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RFC v4 9/9] kmsg: selftests
Date	2015-10-20 15:40 +0200
Message-ID	<qlFiV-59E-1@gated-at.bofh.it> (permalink)
References	<qllWV-1T1-5@gated-at.bofh.it> <qllWX-1T1-35@gated-at.bofh.it> <qloi6-5w7-43@gated-at.bofh.it> <qlD7s-258-7@gated-at.bofh.it>
Organization	Samsung Open Source Group

Show all headers | View raw

On 10/20/2015 05:10 AM, Paul Osmialowski wrote:
> Hi Shuah,
> 
> Thanks for your comments,
> 
> On Mon, 19 Oct 2015, Shuah Khan wrote:
> 
>>> --- a/tools/testing/selftests/Makefile
>>> +++ b/tools/testing/selftests/Makefile
>>> @@ -7,6 +7,7 @@ TARGETS += ftrace
>>>  TARGETS += futex
>>>  TARGETS += kcmp
>>>  TARGETS += kdbus
>>
>> Doesn't look like this patch is based on linux-kselftest next
>> or Linus's latest. Please base your work on either one of the
>> above. Please make sure "make kselftest" from top level Makefile
>> doesn't break.
>>
>>> +TARGETS += kmsg
> 
> Any guidelines what such test should be implemented (apart from use of
> kselftest.h API)?

If kselftest.h works well for reporting errors, please use it.
No requirement on that. The one important thing to remember is
new test shouldn't break "make kselftest" run and install tool
kselftest_install.sh

> 
>>> +kmsg-test: $(OBJS)
>>> +    $(CC) $(CFLAGS) $^ $(LDLIBS) -o $@
>>> +
>>> +run_tests:
>>> +    ./kmsg-test --tap
>>
>> What does --tap do? Is this a longform option?
>> I don't see it in usage()
>>
> 
> Should be removed - I copy-pasted parts of kdbus selftests Makefile not
> noticing that.
> 
> Best regards,
> Paul
> 


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v4 9/9] kmsg: selftests Paul Osmialowski <p.osmialowsk@samsung.com> - 2015-10-19 19:00 +0200
  Re: [RFC v4 9/9] kmsg: selftests Shuah Khan <shuahkh@osg.samsung.com> - 2015-10-19 21:30 +0200
    Re: [RFC v4 9/9] kmsg: selftests Paul Osmialowski <p.osmialowsk@samsung.com> - 2015-10-20 13:20 +0200
      Re: [RFC v4 9/9] kmsg: selftests Shuah Khan <shuahkh@osg.samsung.com> - 2015-10-20 15:40 +0200

csiph-web