Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1251710

Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time

Show all headers | View raw

Hello,

On Tue, 20 Oct 2015 15:46:00 +0200, Gregory CLEMENT wrote:

> > +	/* Re-enable per-CPU interrupts that were enabled before suspend */
> > +	nirqs = (readl(main_int_base + ARMADA_370_XP_INT_CONTROL) >> 2) & 0x3ff;
> > +	for (irq = 0; irq < nirqs; irq++) {
> 
> Actually we could reduce this loop by using
> ARMADA_370_XP_MAX_PER_CPU_IRQS, as we know that we can't have more per
> cpu irq. 

Indeed. I can fix that up in the next version.

> > +		struct irq_data *data;
> > +		int virq;
> > +
> > +		virq = irq_linear_revmap(armada_370_xp_mpic_domain, irq);
> > +		if (virq == 0)
> > +			continue;
> > +
> > +		data = irq_get_irq_data(virq);
> > +
> > +		if (irq != ARMADA_370_XP_TIMER0_PER_CPU_IRQ)
> > +			continue;
> 
> So eventually you only manage the timer IRQs?
> 
> If it is intentional you could it differently, but I wonder why you don't
> enable again the other percpu IRQ.

The idea is to have the same condition at the one used in the
->resume() hook.

In the end, it should be using the is_percpu_irq() function as is done
in linux-next in the ->resume() function. But since this patch is
(hopefully) aimed at 4.3, I've for now kept the same logic as the
current ->resume() function.

> The following chunk will conflict with "irqchip: armada-370-xp: Rework
> per-cpu interrupts handling" which is in Linux next. But as this patch
> is for 4.3, you can't do anything...

Indeed. I intentionally based this series on 4.3-rc, because it's
fixing a regression introduced between 4.2 and 4.3-rc, and therefore as
such should be fixed before 4.3 is released if possible (though I
understand it's already -rc6 time so maybe a bit late).

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-20 15:30 +0200
  Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-20 15:50 +0200
    Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU  interrupts at resume time Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-20 16:00 +0200
  Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts  at resume time Marcin Wojtas <mw@semihalf.com> - 2015-10-25 22:30 +0100
    Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU  interrupts at resume time Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-26 01:20 +0100
      Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts  at resume time Marcin Wojtas <mw@semihalf.com> - 2015-10-26 05:40 +0100
        Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU  interrupts at resume time Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-26 06:20 +0100
          Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts  at resume time Marcin Wojtas <mw@semihalf.com> - 2015-10-26 08:10 +0100
            Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU  interrupts at resume time Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-26 09:30 +0100

csiph-web