Re: [PATCH 5/8] regulator: introduce regulator_get_voltage_floor

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sascha Hauer <s.hauer@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/8] regulator: introduce regulator_get_voltage_floor
Date	Tue, 20 Oct 2015 14:30:02 +0200
Message-ID	<qlEdc-3CF-9@gated-at.bofh.it> (permalink)
References	<qj5jz-45m-3@gated-at.bofh.it> <qj5jz-45m-1@gated-at.bofh.it> <qkgwi-3Qz-25@gated-at.bofh.it>
X-Original-To	Mark Brown <broonie@kernel.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-Sent-From	Pengutronix Hildesheim
X-URL	http://www.pengutronix.de/
X-Irc	#ptxdist @freenode
X-Accept-Language	de,en
X-Accept-Content-Type	text/plain
X-Uptime	14:23:59 up 2 days, 21:02, 47 users, load average: 0.11, 0.05, 0.07
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	2001:67c:670:100:1d::c0
X-Sa-Exim-Mail-From	sha@pengutronix.de
X-Sa-Exim-Scanned	No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-Ptx-Original-Recipient	linux-kernel@vger.kernel.org
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, kernel@pengutronix.de, alkml@pengutronix.de
X-Original-Date	Tue, 20 Oct 2015 14:26:55 +0200
X-Original-Message-ID	<20151020122655.GR14476@pengutronix.de>
X-Original-References	<1444733131-26995-1-git-send-email-s.hauer@pengutronix.de> <1444733131-26995-6-git-send-email-s.hauer@pengutronix.de> <20151016165023.GT14956@sirena.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1251633

Show key headers only | View raw

On Fri, Oct 16, 2015 at 05:50:23PM +0100, Mark Brown wrote:
> On Tue, Oct 13, 2015 at 12:45:28PM +0200, Sascha Hauer wrote:
> 
> > +	num_voltages = regulator_count_voltages(regulator);
> > +	if (num_voltages < 0)
> > +		return num_voltages;
> 
> > +	for (i = 0; i < num_voltages; i++) {
> > +		now = _regulator_list_voltage(regulator, i, 0);
> > +		if (now < 0)
> > +			continue;
> > +		if (now < best && now >= min_uV)
> > +			best = now;
> > +	}
> 
> Why is this not a factoring out of existing code (indeed it is itself a
> reimplementation of regulator_map_voltage_iterate())?  This will also be
> a substantial performance loss in cases where we have a known mapping
> function - we should use a map_voltage() operation if one exists like we
> do in _do_set_voltage().  That has logic to handle missing mapping
> functions as a transition measure, now I look at it we should probably
> remove that code and just require that the mapping function is set if
> appropriate.

I didn't realize the map_voltage functionality is exactly what I want to
have. Turns out that I can factor out a regulator_map_voltage() function
instead of creating a regulator_get_voltage_floor() function. Updated
series follows shortly.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 5/8] regulator: introduce regulator_get_voltage_floor Sascha Hauer <s.hauer@pengutronix.de> - 2015-10-20 14:30 +0200

csiph-web