Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1251508

[PATCH v4 0/4] drm: Cleanup probe function for component based masters.

Show all headers | View raw

Changelog:
v4: Fixed a bug where the wrong pointer was sent to component_match_add() and
    component_master_add_with_match() in the armada_drv.c file that was flagged
    by kbuild test robot. Dropped the RFC tag and added Acked-bys received from
    Russell King.
v3: Removed the call to dma_set_coherent_mask() from the generic
    drm_of_component_probe(). Also changes to shorten lines over 80 chars long.
v2: Rebased the patchset on top of drm-next rather than Linus' latest -rc

A few drivers in drivers/gpu/drm are component-enabled and use quite similar
code sequences to probe for their encoder slaves at the remote end of the ports.
Move the code into a "generic" function and remove it from the drivers.

The end results is that drivers get a reference count fix (imx), more thorough
error checking (imx again) plus a decrease in the overall count of LoC.

I'm looking for comments and testing of the patchset (only compile tested from my
end as I don't have access to all the devices touched by the changes). My main
interest is in finding out if -EINVAL is the correct code to return if
dev->of_node == NULL (handy now, as it is different from the other possible error
codes and used in armada to trigger old platform_data support. Also looking for
thoughts on the correctness of the patch and if it possible to co-opt more drivers
into using the function.

Best regards,
Liviu

Liviu Dudau (4):
  drm: Introduce generic probe function for component based masters.
  drm/imx: Convert the probe function to the generic drm_of_component_probe()
  drm/rockchip: Convert the probe function to the generic drm_of_component_probe()
  drm/armada: Convert the probe function to the generic drm_of_component_probe()

 drivers/gpu/drm/armada/armada_drv.c         | 68 +++++++---------------
 drivers/gpu/drm/drm_of.c                    | 88 +++++++++++++++++++++++++++++
 drivers/gpu/drm/imx/imx-drm-core.c          | 55 ++----------------
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 81 ++------------------------
 include/drm/drm_of.h                        | 13 +++++
 5 files changed, 130 insertions(+), 175 deletions(-)

-- 
2.6.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/4] drm: Cleanup probe function for component based masters. Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-20 11:30 +0200
  [PATCH v4 2/4] drm/imx: Convert the probe function to the generic drm_of_component_probe() Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-20 11:30 +0200
  [PATCH v4 3/4] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-20 11:30 +0200
  [PATCH v4 1/4] drm: Introduce generic probe function for component based masters. Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-20 11:30 +0200
    Re: [PATCH v4 1/4] drm: Introduce generic probe function for  component based masters. Emil Velikov <emil.l.velikov@gmail.com> - 2015-10-20 12:10 +0200
      Re: [PATCH v4 1/4] drm: Introduce generic probe function for  component based masters. Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-20 12:10 +0200
        Re: [PATCH v4 1/4] drm: Introduce generic probe function for  component based masters. Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-20 12:20 +0200
  Re: [PATCH v4 0/4] drm: Cleanup probe function for component based  masters. Daniel Vetter <daniel@ffwll.ch> - 2015-10-20 12:10 +0200
    Re: [PATCH v4 0/4] drm: Cleanup probe function for component based  masters. Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-20 12:20 +0200

csiph-web