Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250284

Re: [PATCH] arm64: change to use memmove in efi-stub

Show all headers | View raw

Got it ,

Thanks for your explanation .
> On Oct 16, 2015, at 18:57, Mark Rutland <mark.rutland@arm.com> wrote:
> 
> Hi,
> 
> On Fri, Oct 16, 2015 at 06:46:07PM +0800, yalin wang wrote:
>> Change to use memmove(), in case the dest address overlap with the
>> source address.
> 
> This cannot happen, and memove would not be sufficient if it did.
> 
> The destination is a region returned by EFI_BOOT_SERVICES.AllocatePages,
> which can only allocate pages which were free to begin with. Therefore
> the new region cannot overlap with the stub (whose pages are not free).
> 
> Were the new region to overlap with the stub, the memmove could corrupt
> the code/data in use by the stub, and things would explode shortly
> thereafter.
> 
> Thanks,
> Mark.
> 
>> 
>> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
>> ---
>> arch/arm64/kernel/efi-stub.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/kernel/efi-stub.c b/arch/arm64/kernel/efi-stub.c
>> index 816120e..b6dc44b 100644
>> --- a/arch/arm64/kernel/efi-stub.c
>> +++ b/arch/arm64/kernel/efi-stub.c
>> @@ -59,7 +59,7 @@ efi_status_t __init handle_kernel_image(efi_system_table_t *sys_table_arg,
>> 			}
>> 			*image_addr = *reserve_addr + TEXT_OFFSET;
>> 		}
>> -		memcpy((void *)*image_addr, old_image_addr, kernel_size);
>> +		memmove((void *)*image_addr, old_image_addr, kernel_size);
>> 		*reserve_size = kernel_memsize;
>> 	}
>> 
>> -- 
>> 1.9.1
>> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: change to use memmove in efi-stub yalin wang <yalin.wang2010@gmail.com> - 2015-10-16 12:50 +0200
  Re: [PATCH] arm64: change to use memmove in efi-stub Mark Rutland <mark.rutland@arm.com> - 2015-10-16 13:00 +0200
    Re: [PATCH] arm64: change to use memmove in efi-stub yalin wang <yalin.wang2010@gmail.com> - 2015-10-19 04:20 +0200

csiph-web