Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250282

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

Show all headers | View raw

On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote:
> On Sat, Oct 17, 2015 at 10:46 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote:
> >> Put constant on the right side of a test.Problem found using checkpatch:
> >>
> >> Warning:Comparisons should place the constant on the right side of the test
> >>
> >> Signed-off-by: Punit Vara <punitvara@gmail.com>
> >> ---
> >>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
> >>  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > Didn't apply to my tree :(
> In this case what should I do ? Should I do git reset , git pull and
> then  do changes on latest tree ?

That depends on your workflow, how about pulling and then rebase your
branch on mine?  That's the easiest workflow to use.

> One more thing I would like suggestion how can start switching this
> driver to LIB80211 ,MAC80211 ? Which is the first file I should focus
> ? Simultaneously I am trying to understand the flow of driver . I
> would like to know the start point  from where I can start doing small
> changes.

If you don't understand the wireless stack, I suggest you do some
research on it first, converting a driver to the in-kernel stack is a
_very_ difficult thing and not something that someone without any
experience in this area is going to be able to do easily.

good luck!

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 0/4] Staging: rtl8712: Fix coding style warnings Punit Vara <punitvara@gmail.com> - 2015-10-14 20:30 +0200
  [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test Punit Vara <punitvara@gmail.com> - 2015-10-14 20:30 +0200
    Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing  constant on the right side of test Greg KH <gregkh@linuxfoundation.org> - 2015-10-17 07:20 +0200
      Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant  on the right side of test punit vara <punitvara@gmail.com> - 2015-10-18 08:40 +0200
        Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant  on the right side of test Tillmann Heidsieck <theidsieck@leenox.de> - 2015-10-18 21:00 +0200
          Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing  constant on the right side of test Tillmann Heidsieck <theidsieck@leenox.de> - 2015-10-18 21:20 +0200
        Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing  constant on the right side of test Greg KH <gregkh@linuxfoundation.org> - 2015-10-19 04:10 +0200
          Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant  on the right side of test Larry Finger <Larry.Finger@lwfinger.net> - 2015-10-19 04:50 +0200
            Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant  on the right side of test punit vara <punitvara@gmail.com> - 2015-10-19 17:30 +0200
              Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant  on the right side of test punit vara <punitvara@gmail.com> - 2015-10-22 21:10 +0200
                Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing  constant on the right side of test Greg KH <gregkh@linuxfoundation.org> - 2015-10-22 21:20 +0200
                Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing  constant on the right side of test Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-22 21:30 +0200
                Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant  on the right side of test punit vara <punitvara@gmail.com> - 2015-10-22 22:10 +0200
                Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing  constant on the right side of test Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-22 22:40 +0200
                Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant  on the right side of test punit vara <punitvara@gmail.com> - 2015-10-24 09:20 +0200
  [PATCH RESEND 1/4] Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over memset() Punit Vara <punitvara@gmail.com> - 2015-10-14 20:30 +0200

csiph-web