Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250246

[PATCH] tty/serial: make early console depend on SERIAL_CORE=y

Show all headers | View raw

On an powerpc allmodconfig build, the following is seen:

paul@builder:~/git/linux-head$ make O=../ppc-build -j30 > /dev/null
drivers/built-in.o: In function `.setup_earlycon':
(.init.text+0x5b00): undefined reference to `.uart_parse_earlycon'
make[1]: *** [vmlinux] Error 1

Since uart_parse_earlycon lives in serial_core.c we need to ensure
it is built in if early console is to be used.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-serial@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[A google shows this cropped up in April of this year; I guess it wasn't
 completely fixed?
 http://lists.infradead.org/pipermail/linux-arm-kernel/2015-April/336954.html
 FWIW, I was testing on tty/tty-testing pulled today, from Greg  ]

 drivers/tty/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1aec4404062d..a646047e4051 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -9,6 +9,7 @@ menu "Serial drivers"
 
 config SERIAL_EARLYCON
 	bool
+	depends on SERIAL_CORE=y
 	help
 	  Support for early consoles with the earlycon parameter. This enables
 	  the console before standard serial driver is probed. The console is
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] tty/serial: make early console depend on SERIAL_CORE=y Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-10-19 00:10 +0200
  Re: [PATCH] tty/serial: make early console depend on SERIAL_CORE=y Arnd Bergmann <arnd@arndb.de> - 2015-10-19 15:00 +0200
    Re: [PATCH] tty/serial: make early console depend on SERIAL_CORE=y Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-10-19 21:20 +0200
    Re: [PATCH] tty/serial: make early console depend on SERIAL_CORE=y Peter Hurley <peter@hurleysoftware.com> - 2015-10-19 21:40 +0200

csiph-web