Re: [PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Marcel Holtmann <marcel@holtmann.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency
Date	Sat, 17 Oct 2015 11:20:01 +0200
Message-ID	<qkvOF-1ds-1@gated-at.bofh.it> (permalink)
References	<qklmi-2Im-29@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
Content-Type	text/plain; charset=us-ascii
MIME-Version	1.0 (Mac OS X Mail 9.0 \(3094\))
Content-Transfer-Encoding	8BIT
X-Mailer	Apple Mail (2.3094)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	"Gustavo F. Padovan" <gustavo@padovan.org>, Johan Hedberg <johan.hedberg@gmail.com>, linux-bluetooth <linux-bluetooth@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel@lists.infradead.org
X-Original-Date	Sat, 17 Oct 2015 11:15:17 +0200
X-Original-Message-ID	<A0A720F0-8950-4B1D-99A9-6A0059E8BF8B@holtmann.org>
X-Original-References	<4199320.WWtqtXexhZ@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1249289

Show key headers only | View raw

Hi Arnd,

> The change to bpa10x to use the h4_recv_buf helper added a dependency
> on BT_HCIUART. This was incorrectly added to Kconfig by adding a
> 'select' statement, which now in turn causes build failures
> when CONFIG_TTY is not set:
> 
> warning: (BT_HCIBPA10X) selects BT_HCIUART which has unmet direct dependencies (NET && BT && TTY)
> vers/built-in.o: In function `hci_uart_tty_receive':
> fpga-mgr.c:(.text+0x282824): undefined reference to `tty_unthrottle'
> drivers/built-in.o: In function `hci_uart_tty_ioctl':
> fpga-mgr.c:(.text+0x282aa0): undefined reference to `n_tty_ioctl_helper'
> drivers/built-in.o: In function `hci_uart_flush':
> 
> This replaces the 'select BT_HCIUART' dependency with 'depends on', which
> does not have this kind of problem. Alternatively, one could add 'depends
> on TTY', but avoiding 'select' on user-visible options is generally the
> preferred choice as that does not introduce the potential for dependency
> loops or incomplete dependency chains.

the intention here was to use select, but that seems to open all sorts of problems. Since I am most likely the only person that still has this device and attaches it to Linux, I am fine in going the easier path with depends on.

Patch has been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency Arnd Bergmann <arnd@arndb.de> - 2015-10-17 00:10 +0200
  Re: [PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency Marcel Holtmann <marcel@holtmann.org> - 2015-10-17 11:20 +0200

csiph-web