Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249272

Re: [PATCH] staging: comedi: fixed few coding style warnings

Show all headers | View raw

On Wed, Oct 14, 2015 at 07:33:00PM +0530, Sakshi Bansal wrote:
> Fixed block comments usage of * on subsequent lines
> 
> Signed-off-by: Sakshi Bansal <sakshi.april5@gmail.com>
> ---
>  drivers/staging/comedi/comedi.h        | 181 +++++++++++++++++++--------------
>  drivers/staging/comedi/comedi_pcmcia.h |   3 +-
>  drivers/staging/comedi/comedilib.h     |  26 ++---
>  3 files changed, 120 insertions(+), 90 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 66edda1..31a43ee 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -1,20 +1,20 @@
>  /*
> -    include/comedi.h (installed as /usr/include/comedi.h)
> -    header file for comedi
> + *  include/comedi.h (installed as /usr/include/comedi.h)
> + *  header file for comedi
>  
> -    COMEDI - Linux Control and Measurement Device Interface
> -    Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org>
> + *  COMEDI - Linux Control and Measurement Device Interface
> + *  Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org>
>  
> -    This program is free software; you can redistribute it and/or modify
> -    it under the terms of the GNU Lesser General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU Lesser General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
>  

Why are you leaving the blank lines alone?  Either do it all or nothing,
what you are doing here is not correct at all :(

Hint, please leave these alone, there's nothing wrong with the existing
format.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: comedi: fixed few coding style warnings Sakshi Bansal <sakshi.april5@gmail.com> - 2015-10-14 16:10 +0200
  Re: [PATCH] staging: comedi: fixed few coding style warnings Greg KH <gregkh@linuxfoundation.org> - 2015-10-17 08:30 +0200

csiph-web