Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249232

Re: [PATCH 01/10] clk: rockchip: Add sclk_mipidsi_24m for mipi dsi

Show all headers | View raw

On 10/17/2015 05:39 AM, Stephen Boyd wrote:
> On 10/10, Chris Zhong wrote:
>> sclk_mipidsi_24m is the gating of mipi dsi phy.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>> ---
> Acked-by: Stephen Boyd <sboyd@codeaurora.org>
>
>>   drivers/clk/rockchip/clk-rk3288.c      | 2 +-
>>   include/dt-bindings/clock/rk3288-cru.h | 1 +
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
>> index 9040878..c7d7ebf 100644
>> --- a/drivers/clk/rockchip/clk-rk3288.c
>> +++ b/drivers/clk/rockchip/clk-rk3288.c
>> @@ -709,7 +709,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = {
>>   	GATE(SCLK_LCDC_PWM1, "sclk_lcdc_pwm1", "xin24m", 0, RK3288_CLKGATE_CON(13), 11, GFLAGS),
>>   	GATE(SCLK_PVTM_CORE, "sclk_pvtm_core", "xin24m", 0, RK3288_CLKGATE_CON(5), 9, GFLAGS),
>>   	GATE(SCLK_PVTM_GPU, "sclk_pvtm_gpu", "xin24m", 0, RK3288_CLKGATE_CON(5), 10, GFLAGS),
>> -	GATE(0, "sclk_mipidsi_24m", "xin24m", 0, RK3288_CLKGATE_CON(5), 15, GFLAGS),
>> +	GATE(SCLK_MIPI_24M, "sclk_mipidsi_24m", "xin24m", 0, RK3288_CLKGATE_CON(5), 15, GFLAGS),
>>   
> It would have been better to make #defines for all these clocks
> even if they weren't going to be used here. Then we could have
> applied this patch directly to clk tree without having a clk tree
> to arm-soc dependency. </grumble>
>
Thanks for your great suggestion, I'll defines all clocks at next 
version patch serial

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] Add mipi dsi support for rk3288 Chris Zhong <zyw@rock-chips.com> - 2015-10-10 12:00 +0200
  [PATCH 03/10] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format Chris Zhong <zyw@rock-chips.com> - 2015-10-10 12:00 +0200
  [PATCH 01/10] clk: rockchip: Add sclk_mipidsi_24m for mipi dsi Chris Zhong <zyw@rock-chips.com> - 2015-10-10 12:00 +0200
    Re: [PATCH 01/10] clk: rockchip: Add sclk_mipidsi_24m for mipi dsi Stephen Boyd <sboyd@codeaurora.org> - 2015-10-16 23:40 +0200
      Re: [PATCH 01/10] clk: rockchip: Add sclk_mipidsi_24m for mipi dsi Chris Zhong <zyw@rock-chips.com> - 2015-10-17 03:00 +0200
  [PATCH 06/10] drm: rockchip: Support Synopsys DesignWare MIPI DSI host controller Chris Zhong <zyw@rock-chips.com> - 2015-10-10 12:00 +0200
  [PATCH 07/10] Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver Chris Zhong <zyw@rock-chips.com> - 2015-10-10 12:00 +0200
  [PATCH 10/10] ARM: dts: rockchip: add support mipi panel tv080wum-nl0 for rk3288-evb Chris Zhong <zyw@rock-chips.com> - 2015-10-10 12:00 +0200
  [PATCH 04/10] Documentation: dt-bindings: Add bindings for Synopsys DW MIPI DSI DRM bridge driver Chris Zhong <zyw@rock-chips.com> - 2015-10-10 12:00 +0200
  [PATCH 05/10] drm/bridge: Add Synopsys DesignWare MIPI DSI host controller driver Chris Zhong <zyw@rock-chips.com> - 2015-10-10 12:00 +0200
    Re: [PATCH 05/10] drm/bridge: Add Synopsys DesignWare MIPI DSI host  controller driver kbuild test robot <lkp@intel.com> - 2015-10-11 09:30 +0200

csiph-web