Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1249180
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency |
| Date | Sat, 17 Oct 2015 00:10:02 +0200 |
| Message-ID | <qklmi-2Im-29@gated-at.bofh.it> (permalink) |
| X-Original-To | Marcel Holtmann <marcel@holtmann.org>, Gustavo Padovan <gustavo@padovan.org> |
| User-Agent | KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) |
| MIME-Version | 1.0 |
| Content-Transfer-Encoding | 7Bit |
| Content-Type | text/plain; charset="us-ascii" |
| X-Provags-ID | V03:K0:G+z9AzOedRGAtzEGaa500RCPOjQxaW+UYUjFURkxuLil1pYbj1G blka/IuWhS6Ish2l0mN5p86s6vuzsdTTmEezfnhRWyqjiVYGsItR8j6eLXasBfR7EpR4dlW aUxOi22WonkZ+KAHDCyxNbGo2492WP1oWHJtf96QZQV2guROlsV7kacKynFdfJeTSUVhv4U ojWaIs2+UF8XqrNB7KM+A== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:1gOkRmOQ+Qw=:GcMGcVl8TBHFTyY0zbZn97 xfaOpbpc1+yOcvtmi9WUXgpBpIXTc8v6cn6lm5vkiWXzmLnpuvL1UpTMOOsQtBLcAD17Fasr3 LMUUONg7InKgORRJN76Lq1dfmkHaxcPXAA6ak2dRD44cJz+5UTqAJNqFZrjP9UHK9VXhb4nO7 yjTEQXtYTNT8QmWdF6r1soiSkh6GoMvmuWDvQyukREm22swax7fHJs8nK5eRmv1Rqm5Ru+YXo bOgZ5dfxUH+uMh4XTw21aQ1F7b2BobDz8ulv3zyFFaV30l7pkGktsojuqiOIja9k1aoN1aCFF wbTMm5YQdp9srXHClmSjrMCob8bsG+AELQrEQRMpVr2glLXnm6oVKJXD8EK0Pzs1oVVOtSMTn I/VLGoPrUJfxczHyYwfx9iVV+L7y1HHxZ5E3ljT0Vnuy8P8gTKYshqV7kuiugtSiYwt7Lo5Yk gLP71VEXU/UurX6ixXLqDxS3qwyQKQMByhOIGuNlm6Ikcre7lO5dt9tSUkDOhTcfFelQI80H1 HZLnzDPJr9UOm7srOepeubDktfjFU5PrDtCLYcy9OK9DR4vN4U+qu576yZ9G74UtSlqz7/tDJ 7T2cJB4mcb3QaZMr78hep8YeFk9YcVp8MUbpC2N6ZO70XNZyHFvfzZPqdu1PK72imdWGjWvfi Hpw6EVkilDoTV/PEPoWbSktcj1Bqge1OiW8vWEppzS+2faAkHnwZMfWX/3OywKvD4oooA9uTy toIfzgboXMAhZjT2 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 44 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Johan Hedberg <johan.hedberg@gmail.com>, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org |
| X-Original-Date | Sat, 17 Oct 2015 00:03:38 +0200 |
| X-Original-Message-ID | <4199320.WWtqtXexhZ@wuerfel> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1249180 |
Show key headers only | View raw
The change to bpa10x to use the h4_recv_buf helper added a dependency
on BT_HCIUART. This was incorrectly added to Kconfig by adding a
'select' statement, which now in turn causes build failures
when CONFIG_TTY is not set:
warning: (BT_HCIBPA10X) selects BT_HCIUART which has unmet direct dependencies (NET && BT && TTY)
vers/built-in.o: In function `hci_uart_tty_receive':
fpga-mgr.c:(.text+0x282824): undefined reference to `tty_unthrottle'
drivers/built-in.o: In function `hci_uart_tty_ioctl':
fpga-mgr.c:(.text+0x282aa0): undefined reference to `n_tty_ioctl_helper'
drivers/built-in.o: In function `hci_uart_flush':
This replaces the 'select BT_HCIUART' dependency with 'depends on', which
does not have this kind of problem. Alternatively, one could add 'depends
on TTY', but avoiding 'select' on user-visible options is generally the
preferred choice as that does not introduce the potential for dependency
loops or incomplete dependency chains.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: a4a4affca68c ("Bluetooth: bpa10x: Fix missing BT_HCIUART dependency")
Fixes: 943cc592195e ("Bluetooth: bpa10x: Use h4_recv_buf helper for frame reassembly")
---
Found on ARM randconfig builds
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index fcf52fdb1ba3..ec6af1595062 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -183,8 +183,7 @@ config BT_HCIBCM203X
config BT_HCIBPA10X
tristate "HCI BPA10x USB driver"
- depends on USB
- select BT_HCIUART
+ depends on USB && BT_HCIUART
select BT_HCIUART_H4
help
Bluetooth HCI BPA10x USB driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency Arnd Bergmann <arnd@arndb.de> - 2015-10-17 00:10 +0200 Re: [PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency Marcel Holtmann <marcel@holtmann.org> - 2015-10-17 11:20 +0200
csiph-web