Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249191

[PATCH] stm: add configfs dependency

Show all headers | View raw

There are three new stm modules, all of which use configfs for configuration.
If configfs is not part of the kernel, or is a loadable module while
the stm driver is builtin, we get a link error like:

drivers/built-in.o: In function `stp_policy_node_drop':
drivers/hwtracing/stm/policy.c:232: undefined reference to `config_item_put'
drivers/built-in.o: In function `stp_policies_make':
drivers/hwtracing/stm/policy.c:352: undefined reference to `config_group_init_type_name'
drivers/built-in.o: In function `stp_policy_node_make':
drivers/hwtracing/stm/policy.c:215: undefined reference to `config_group_init_type_name'

This adds explicit Kconfig dependencies to ensure configfs is present.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
The patches are currently in Greg's char-misc tree, we should have
this one in the same branch.

diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 5a59a28cc3da..6df294fff1eb 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -1,5 +1,6 @@
 config STM
 	tristate "System Trace Module devices"
+	depends on CONFIGFS_FS
 	help
 	  A System Trace Module (STM) is a device exporting data in System
 	  Trace Protocol (STP) format as defined by MIPI STP standards.
@@ -9,6 +10,7 @@ config STM
 
 config STM_DUMMY
 	tristate "Dummy STM driver"
+	depends on CONFIGFS_FS
 	help
 	  This is a simple dummy device that pretends to be an stm device
 	  and discards your data. Use for stm class testing.
@@ -17,6 +19,7 @@ config STM_DUMMY
 
 config STM_SOURCE_CONSOLE
 	tristate "Kernel console over STM devices"
+	depends on CONFIGFS_FS
 	help
 	  This is a kernel space trace source that sends kernel log
 	  messages to trace hosts over STM devices.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] stm: add configfs dependency Arnd Bergmann <arnd@arndb.de> - 2015-10-17 00:40 +0200
  Re: [PATCH] stm: add configfs dependency Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-17 08:30 +0200

csiph-web