Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249120

Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller

Show all headers | View raw

On Thu, Oct 8, 2015 at 9:49 PM, Andreas Werner <andy@wernerandy.de> wrote:

> if i will implement the open drain support, does it really makes sense to go with the
> generic gpio lib?

Open Drain yes, for more esoterin pin config you may need to
also implement pin control, see Documentation/pinctrl.txt

> I need to replace the direction_input and direction_outpu functions
> because if the userland set an open drain pin to input i need to
> set the pin to High-Z (driver "1") instead of setting the input bit
> in the direction register.

Laurent has the same usecase I think, we need some fixes but
then we can detect (in the driver) that the gpio descriptor has
the open drain flag set in the .request() callback so you
can set it up there.

> So at the end there are just the "set" and "dat"
> functions used to drive an output and to get an input state.
> Alle other functions needs to be implemented in the driver.

I don't understand this question.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller Linus Walleij <linus.walleij@linaro.org> - 2015-10-06 09:40 +0200
  Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller Andreas Werner <andy@wernerandy.de> - 2015-10-06 20:00 +0200
  Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller Andreas Werner <andy@wernerandy.de> - 2015-10-08 19:00 +0200
    Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller Linus Walleij <linus.walleij@linaro.org> - 2015-10-16 22:00 +0200
  Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller Andreas Werner <andy@wernerandy.de> - 2015-10-08 21:50 +0200
    Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller Linus Walleij <linus.walleij@linaro.org> - 2015-10-16 22:00 +0200

csiph-web