Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249112

Re: [PATCH] x86/entry/32: Fix entry_INT80_32 to expect interrupts to be on

Show all headers | View raw

On Fri, Oct 16, 2015 at 11:47:11AM -0700, Andy Lutomirski wrote:
> When I rewrote entry_INT80_32, I thought that int80 was an interrupt
> gate.  It's a trap gate.  *facepalm*
> 
> Thanks to Brian Gerst for pointing out that it's better to change
> the entry code than to change the gate type.
> 
> Suggested-by: Brian Gerst <brgerst@gmail.com>
> Reported-by: Borislav Petkov <bp@suse.de>
> Fixes: 150ac78d63af ("x86/entry/32: Switch INT80 to the new C syscall path")
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> 
> I can reproduce Borislav's warning with an appropriate .config, and this
> patch fixes it.  I removed the Tested-by, because it's not the same fix
> that Borislav tested.

You can re-add it. Looks good.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/entry/32: Fix entry_INT80_32 to expect interrupts to be on Andy Lutomirski <luto@kernel.org> - 2015-10-16 20:50 +0200
  Re: [PATCH] x86/entry/32: Fix entry_INT80_32 to expect interrupts to  be on Borislav Petkov <bp@alien8.de> - 2015-10-16 21:50 +0200
    Re: [PATCH] x86/entry/32: Fix entry_INT80_32 to expect interrupts to  be on Andy Lutomirski <luto@amacapital.net> - 2015-10-16 22:20 +0200

csiph-web