Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249102

Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64

Show all headers | View raw

On Friday 16 October 2015 09:54:45 Brian Norris wrote:
> > MTD_NAND_BRCMNAND uses the generic nand functions, but is currently allowed
> > to be built without CONFIG_MTD_NAND, which results in a link error:
> > 
> > drivers/built-in.o: In function `brcmnand_remove':
> > coresight-replicator.c:(.text+0x17ae6c): undefined reference to `nand_release'
> > drivers/built-in.o: In function `brcmnand_probe':
> > coresight-replicator.c:(.text+0x17d4b4): undefined reference to `nand_scan_ident'
> > coresight-replicator.c:(.text+0x17d948): undefined reference to `nand_scan_tail'
> 
> How did you get this? MTD_NAND_BRCMNAND is surrounded in the
> 'if MTD_NAND' block, which implicitly generates a MTD_NAND dependency.
> And I can confirm that in menuconfig, I see this when I disable MTD_NAND
> and search for BRCMNAND:
> 
>    Symbol: MTD_NAND_BRCMNAND [=n]
>    Type  : tristate
>    Prompt: Broadcom STB NAND controller
>      Location:
>        -> Device Drivers
>          -> Memory Technology Device (MTD) support (MTD [=y])
>    (1)     -> NAND Device Support (MTD_NAND [=n])
>      Defined at drivers/mtd/nand/Kconfig:394
>      Depends on: MTD [=y] && MTD_NAND [=n] && (ARM [=y] || ARM64 || MIPS)

Sorry, can't reproduce it any more. My patch is dated June 4, so it was
probably broken then but got fixed since. I normally try to verify that
the patches are still needed before I send them, but this time I only
saw the current discussion and remembered something vague about it
and sent what I had in my backlog of the randconfig-fixes series.

Sorry for the confusion.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] NAND support for Broadcom NS2 SoC Anup Patel <anup.patel@broadcom.com> - 2015-10-16 11:10 +0200
  [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64 Anup Patel <anup.patel@broadcom.com> - 2015-10-16 11:10 +0200
    Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected  for ARM64 Ray Jui <rjui@broadcom.com> - 2015-10-16 17:40 +0200
      Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected  for ARM64 Brian Norris <computersforpeace@gmail.com> - 2015-10-16 18:50 +0200
    Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-10-16 18:30 +0200
      Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected  for ARM64 Brian Norris <computersforpeace@gmail.com> - 2015-10-16 19:00 +0200
        Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected  for ARM64 Florian Fainelli <f.fainelli@gmail.com> - 2015-10-16 21:30 +0200
          Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-10-16 21:40 +0200
        Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-10-16 21:30 +0200
  [PATCH v2 4/4] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Anup Patel <anup.patel@broadcom.com> - 2015-10-16 11:10 +0200
  [PATCH v2 3/4] mtd: brcmnand: Force 8bit mode before doing nand_scan_ident() Anup Patel <anup.patel@broadcom.com> - 2015-10-16 11:10 +0200
  [PATCH v2 1/4] mtd: brcmnand: Fix pointer type-cast in brcmnand_write() Anup Patel <anup.patel@broadcom.com> - 2015-10-16 11:20 +0200
    Re: [PATCH v2 1/4] mtd: brcmnand: Fix pointer type-cast in  brcmnand_write() Ray Jui <rjui@broadcom.com> - 2015-10-16 17:40 +0200
      Re: [PATCH v2 1/4] mtd: brcmnand: Fix pointer type-cast in  brcmnand_write() Brian Norris <computersforpeace@gmail.com> - 2015-10-16 18:50 +0200
      RE: [PATCH v2 1/4] mtd: brcmnand: Fix pointer type-cast in  brcmnand_write() Anup Patel <anup.patel@broadcom.com> - 2015-10-17 05:00 +0200

csiph-web