Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1249097

Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt

From Stephen Boyd <sboyd@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt
Date 2015-10-16 21:30 +0200
Message-ID <qkiRt-7pv-31@gated-at.bofh.it> (permalink)
References <qjTq2-3aG-11@gated-at.bofh.it> <qjTq4-3aG-67@gated-at.bofh.it> <qjW4x-7c7-5@gated-at.bofh.it> <qk5Ue-51N-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/16, Viresh Kumar wrote:
> On 15-10-15, 12:04, Stephen Boyd wrote:
> > On 10/15, Viresh Kumar wrote:
> > > With debug options on, it is difficult to locate OPP core's debug
> > > prints. Fix this by prefixing OPP debug prints with KBUILD_MODNAME.
> > > 
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > 
> > Why not use dynamic debug's m flag to turn on KBUILD_MODNAME when
> > debugging?
> > 
> > >From Documentation/dynamic-debug-howto.txt
> > 
> >   m    Include module name in the printed message
> 
> It wasn't just about debug messages but pr_info and pr_err as well.
> And so I defined pr_fmt instead.
> 

Ok, well the commit text exclusively mentions debug, leading me
to believe this is all about making the debug prints (i.e.
pr_debug) have KBUILD_MODNAME. 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-15 18:20 +0200
  Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt Stephen Boyd <sboyd@codeaurora.org> - 2015-10-15 21:10 +0200
    Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-16 07:40 +0200
      Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt Stephen Boyd <sboyd@codeaurora.org> - 2015-10-16 21:30 +0200
        [PATCH V3 1/4] PM / OPP: Improve print messages with pr_fmt Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-17 06:20 +0200

csiph-web