Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249036

Re: [PATCH] usb: dwc2: host: Protect PCGCTL with lock in dwc2_port_resume()

Show all headers | View raw

On 10/14/2015 3:58 PM, Douglas Anderson wrote:
> From code inspection, it appears to be unsafe to do a read-modify-write
> of PCGCTL in dwc2_port_resume().  Let's make sure the spinlock is held
> around this operation.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>  drivers/usb/dwc2/hcd.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index af4e4a2..e79baf7 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -1500,6 +1500,8 @@ static void dwc2_port_resume(struct dwc2_hsotg *hsotg)
>  	u32 hprt0;
>  	u32 pcgctl;
>  
> +	spin_lock_irqsave(&hsotg->lock, flags);
> +
>  	/*
>  	 * If hibernation is supported, Phy clock is already resumed
>  	 * after registers restore.
> @@ -1508,10 +1510,11 @@ static void dwc2_port_resume(struct dwc2_hsotg *hsotg)
>  		pcgctl = dwc2_readl(hsotg->regs + PCGCTL);
>  		pcgctl &= ~PCGCTL_STOPPCLK;
>  		dwc2_writel(pcgctl, hsotg->regs + PCGCTL);
> +		spin_unlock_irqrestore(&hsotg->lock, flags);
>  		usleep_range(20000, 40000);
> +		spin_lock_irqsave(&hsotg->lock, flags);
>  	}
>  
> -	spin_lock_irqsave(&hsotg->lock, flags);
>  	hprt0 = dwc2_read_hprt0(hsotg);
>  	hprt0 |= HPRT0_RES;
>  	hprt0 &= ~HPRT0_SUSP;
> 


Acked-by: John Youn <johnyoun@synopsys.com>


John

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: dwc2: host: Protect PCGCTL with lock in dwc2_port_resume() Douglas Anderson <dianders@chromium.org> - 2015-10-15 01:00 +0200
  Re: [PATCH] usb: dwc2: host: Protect PCGCTL with lock in  dwc2_port_resume() John Youn <John.Youn@synopsys.com> - 2015-10-16 20:10 +0200

csiph-web