Re: [PATCH 6/8] regulator: core: Propagate voltage changes to supply regulators

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/8] regulator: core: Propagate voltage changes to supply regulators
Date	2015-10-16 19:00 +0200
Message-ID	<qkgwh-3Qz-9@gated-at.bofh.it> (permalink)
References	<qj5jz-45m-3@gated-at.bofh.it> <qj5jB-45m-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Oct 13, 2015 at 12:45:29PM +0200, Sascha Hauer wrote:

> +		best_supply_uV = regulator_get_voltage_floor(regulator, min_uV);
> +		if (best_supply_uV < 0) {
> +			ret = best_supply_uV;
> +			goto out2;
> +		}

Now I look at the user here this is just the map voltage operation.  We
could even refactor...

>  	ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
>  	if (ret < 0)
>  		goto out2;

...do_set_voltage() so that we only do the mapping once, though that
gets tricky as we still support devices that don't have mapping
configured :/ .

Otherwise this looks good.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] regulator: Propagate voltage changes to supply regulators Sascha Hauer <s.hauer@pengutronix.de> - 2015-10-13 12:50 +0200
  [PATCH 4/8] regulator: core: introduce function to lock regulators and its supplies Sascha Hauer <s.hauer@pengutronix.de> - 2015-10-13 12:50 +0200
  [PATCH 3/8] regulator: introduce min_dropout_uv Sascha Hauer <s.hauer@pengutronix.de> - 2015-10-13 12:50 +0200
    Re: [PATCH 3/8] regulator: introduce min_dropout_uv Mark Brown <broonie@kernel.org> - 2015-10-16 18:20 +0200
    Applied "regulator: introduce min_dropout_uv" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-10-16 18:50 +0200
      Re: Applied "regulator: introduce min_dropout_uv" to the regulator  tree Mark Brown <broonie@kernel.org> - 2015-10-16 19:00 +0200
  [PATCH 6/8] regulator: core: Propagate voltage changes to supply regulators Sascha Hauer <s.hauer@pengutronix.de> - 2015-10-13 12:50 +0200
    Re: [PATCH 6/8] regulator: core: Propagate voltage changes to supply  regulators Mark Brown <broonie@kernel.org> - 2015-10-16 19:00 +0200

csiph-web