Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1248970

Re: [PATCH] Disable -Wframe-larger-than warnings with KASAN=y

From Andi Kleen <ak@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Disable -Wframe-larger-than warnings with KASAN=y
Date 2015-10-16 18:50 +0200
Message-ID <qkgmB-3Fg-1@gated-at.bofh.it> (permalink)
References <qgbOx-5x8-3@gated-at.bofh.it> <qkfJU-2V2-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Oct 16, 2015 at 07:02:10PM +0300, Andrey Ryabinin wrote:
> When the kernel compiled with KASAN=y, GCC adds redzones
> for each variable on stack. This enlarges function's stack
> frame and causes:
> 	'warning: the frame size of X bytes is larger than Y bytes'
> 
> The worst case I've seen for now is following:
>  ../net/wireless/nl80211.c: In function ‘nl80211_send_wiphy’:
>  ../net/wireless/nl80211.c:1731:1: warning: the frame size of 5448 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>   }
>    ^
> That kind of warning becomes useless with KASAN=y. It doesn't necessarily
> indicate that there is some problem in the code, thus we should turn it off.

If KASAN is really bloating the stack that much you may need to consider
increasing the stack size with KASAN on. We have 16K now, but even that
may not be enough if you more than double it.

Otherwise it may just crash with KASAN on in more complex setups.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] Disable -Wframe-larger-than warnings with KASAN=y Andrey Ryabinin <aryabinin@virtuozzo.com> - 2015-10-16 18:10 +0200
  Re: [PATCH] Disable -Wframe-larger-than warnings with KASAN=y Andi Kleen <ak@linux.intel.com> - 2015-10-16 18:50 +0200
    Re: [PATCH] Disable -Wframe-larger-than warnings with KASAN=y Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-10-16 19:20 +0200

csiph-web