Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect
Date	2015-10-16 18:00 +0200
Message-ID	<qkfAf-2um-41@gated-at.bofh.it> (permalink)
References	<qkf7c-1SN-27@gated-at.bofh.it> <qkfqx-2iA-9@gated-at.bofh.it> <qkfqy-2iA-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. <fcooper@ti.com> wrote:
>
>
> On 10/16/2015 10:45 AM, Andy Shevchenko wrote:
>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>>> SPI controllers may need to be properly setup before chip selects
>>> can be used. Therefore, wait until the spi controller has a chance
>>> to perform their setup procedure before trying to use the chip
>>> select.
>>>
>>> This also insures that the chip selects pins are in a good
>>> state before asseting them which otherwise may cause confusion.
>>>
>>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> Does it mean I have to test it again?
> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included.

Whatever Mark prefers.


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] spi: Setup the master controller driver before setting the chipselect Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-16 17:30 +0200
  Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-16 17:50 +0200
    Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-16 17:50 +0200
      Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-16 18:00 +0200

csiph-web