Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248648

Re: [PATCH v2] rtc: pcf8563: add CLKOUT to common clock framework

Show all headers | View raw

On 16/10/2015 at 12:54:46 +0200, Alexandre Belloni wrote :
> > +static struct clk *pcf8563_clkout_register_clk(struct pcf8563 *pcf8563)
> > +{
> > +	struct i2c_client *client = pcf8563->client;
> > +	struct device_node *node = client->dev.of_node;
> > +	struct clk *clk;
> > +	struct clk_init_data init;
> > +	int ret;
> > +	unsigned char buf;
> > +
> > +	/* disable the clkout output */
> > +	buf = 0;
> > +	ret = pcf8563_write_block_data(client, PCF8563_REG_CLKO, 1, &buf);
> > +	if (ret < 0)
> > +		return ERR_PTR(ret);
> > +
> 
> Isn't that done automatically for an unused clock? However, I would do
> that in the probe as you will have to sprinkle some #ifdef
> CONFIG_COMMON_CLK after seeing the kbuild report.

I'm rethinking about your comment about breaking existing boards. I'd
say that probably nobody is using the output from the rtc but maybe
(highly unlikely) some are configuring it from the bootloader and in
that case it is not nice to undo that configuration. Let's keep that
block here as long as it works fine for you.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] rtc: pcf8563: add CLKOUT to common clock framework Heiko Schocher <hs@denx.de> - 2015-10-16 10:00 +0200
  Re: [PATCH v2] rtc: pcf8563: add CLKOUT to common clock framework kbuild test robot <lkp@intel.com> - 2015-10-16 12:50 +0200
  Re: [PATCH v2] rtc: pcf8563: add CLKOUT to common clock framework Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-16 13:00 +0200
    Re: [PATCH v2] rtc: pcf8563: add CLKOUT to common clock framework Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-16 13:10 +0200
      Re: [PATCH v2] rtc: pcf8563: add CLKOUT to common clock framework Heiko Schocher <hs@denx.de> - 2015-10-16 13:40 +0200

csiph-web