Re: [PATCH V3] debugfs: Add debugfs_create_ulong()

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3] debugfs: Add debugfs_create_ulong()
Date	2015-10-18 19:20 +0200
Message-ID	<qkZMJ-3gD-1@gated-at.bofh.it> (permalink)
References	<qkSie-OV-1@gated-at.bofh.it> <qkZ0m-25Y-23@gated-at.bofh.it> <qkZjI-2st-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Oct 18, 2015 at 10:14:09PM +0530, Viresh Kumar wrote:
> On 18-10-15, 09:21, Greg Kroah-Hartman wrote:
> > On Sun, Oct 18, 2015 at 02:45:27PM +0530, Viresh Kumar wrote:
> > > Add debugfs_create_ulong() for the users of type 'unsigned long'. These
> > > will be 32 bits long on a 32 bit machine and 64 bits long on a 64 bit
> > > machine.
> > 
> > Do you really need a debugfs_create_xlong()?  You don't mention it here
> > in your changelog comment yet the patch contains it.  I'd hold off for
> > it for now as I doubt anyone needs it...
> 
> At least my use case doesn't need it, but I thought it will be better
> to implement the ulong series in the same way other interfaces are
> implemented.
> 
> I can drop that part if you want.

Please do, I don't like adding apis that no one uses.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3] debugfs: Add debugfs_create_ulong() Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-18 11:20 +0200
  Re: [PATCH V3] debugfs: Add debugfs_create_ulong() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-18 18:30 +0200
    Re: [PATCH V3] debugfs: Add debugfs_create_ulong() Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-18 18:50 +0200
      Re: [PATCH V3] debugfs: Add debugfs_create_ulong() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-18 19:20 +0200

csiph-web