Re: [PATCH V2] debugfs: Add debugfs_create_ulong()

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] debugfs: Add debugfs_create_ulong()
Date	2015-10-18 07:20 +0200
Message-ID	<qkOxY-3L2-11@gated-at.bofh.it> (permalink)
References	<qhHt0-5GT-17@gated-at.bofh.it> <qhJuN-9F-1@gated-at.bofh.it> <qjzrk-7fk-21@gated-at.bofh.it> <qjKZr-7If-11@gated-at.bofh.it> <qjVrP-65I-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 15, 2015 at 11:25:55AM -0700, Stephen Boyd wrote:
> On 10/15, Viresh Kumar wrote:
> > On 14-10-15, 11:51, Stephen Boyd wrote:
> > > On 10/09, Viresh Kumar wrote:
> > > > +struct dentry *debugfs_create_xlong(const char *name, umode_t mode,
> > > > +				    struct dentry *parent, unsigned long *value)
> > > > +{
> > > > +	return debugfs_create_file(name, mode, parent, value, &fops_xlong);
> > > 
> > > Were you going to refresh this on my debugfs_create_mode()
> > > patches? Otherwise the patch looks fine to me.
> > 
> > I thought you need to refresh your set as I posted this before you
> > have :)
> > 
> 
> :)
> 
> Well this patch is creating xlong without any
> read-only/write-only ops, so it has the same potential problems
> as what the debugfs_create_mode() series was fixing. I'm fine
> either way though.

Viresh, please rebase your patch on top of Stephen's series, it should
make your patch much smaller.  I've applied his series to my tree now.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] debugfs: Add debugfs_create_ulong() Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-09 17:10 +0200
  Re: [PATCH] debugfs: Add debugfs_create_ulong() Stephen Boyd <sboyd@codeaurora.org> - 2015-10-09 18:40 +0200
  [PATCH V2] debugfs: Add debugfs_create_ulong() Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-09 19:20 +0200
    Re: [PATCH V2] debugfs: Add debugfs_create_ulong() Stephen Boyd <sboyd@codeaurora.org> - 2015-10-14 21:00 +0200
      Re: [PATCH V2] debugfs: Add debugfs_create_ulong() Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-15 09:20 +0200
        Re: [PATCH V2] debugfs: Add debugfs_create_ulong() Stephen Boyd <sboyd@codeaurora.org> - 2015-10-15 20:30 +0200
          Re: [PATCH V2] debugfs: Add debugfs_create_ulong() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-18 07:20 +0200

csiph-web