Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249672

Re: [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address

Show all headers | View raw

Am Freitag, 16. Oktober 2015, 20:40:20 schrieb Jarkko Sakkinen:
> +       pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) +
> +               (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low));

The canonical form would be 
> +       pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) |
> +               (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low));
?
Or am I missing something?
Shall I fix-up?

Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-10-16 20:50 +0200
  Re: [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address Peter Hüwe <PeterHuewe@gmx.de> - 2015-10-18 05:00 +0200
    Re: [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command  buffer address Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-10-18 13:20 +0200

csiph-web