Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248514

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

Show all headers | View raw

On 16/10/15 09:53, Lars-Peter Clausen wrote:
> On 10/16/2015 10:25 AM, Jon Hunter wrote:
>> On driver removal, before killing any tasklets, ensure that the channel
>> interrupts are disabled so that the tasklet will not try to run during
>> or after the removal of the driver.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>  drivers/dma/tegra20-apb-dma.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
>> index 2bfab8d28b53..0dd6e7deaa8e 100644
>> --- a/drivers/dma/tegra20-apb-dma.c
>> +++ b/drivers/dma/tegra20-apb-dma.c
>> @@ -1492,6 +1492,7 @@ static int tegra_dma_remove(struct platform_device *pdev)
>>  
>>  	for (i = 0; i < tdma->chip_data->nr_channels; ++i) {
>>  		tdc = &tdma->channels[i];
>> +		disable_irq(tdc->irq);
> 
> How about just calling free_irq()? That's how you'd typically handle this.

Yes, however, the interrupt is requested by devm_request_irq(). I guess
I could call devm_free_irq() here?

Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal Jon Hunter <jonathanh@nvidia.com> - 2015-10-16 10:30 +0200
  Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal Lars-Peter Clausen <lars@metafoo.de> - 2015-10-16 11:00 +0200
    Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal Jon Hunter <jonathanh@nvidia.com> - 2015-10-16 11:30 +0200
      Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal Lars-Peter Clausen <lars@metafoo.de> - 2015-10-16 12:50 +0200
        Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal Jon Hunter <jonathanh@nvidia.com> - 2015-10-16 13:00 +0200

csiph-web