Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248536

Re: [PATCH] genirq/msi: Do not use pci_msi_[un]mask_irq as default methods

Show all headers | View raw

Bjorn,

On Thu, 15 Oct 2015, Thomas Gleixner wrote:
> On Tue, 13 Oct 2015, Marc Zyngier wrote:
> 
> > When we create a generic MSI domain, that MSI_FLAG_USE_DEF_CHIP_OPS
> > is set, and that any of .mask or .unmask are NULL in the irq_chip
> > structure, we set them to pci_msi_[un]mask_irq.
> > 
> > This is a bad idea for at least two reasons:
> > - PCI_MSI might not be selected, kernel fails to build (yes, this is
> >   legitimate, at least on arm64!)
> > - This may not be a PCI/MSI domain at all (platform MSI, for example)
> > 
> > Either way, this looks wrong. Move the overriding of mask/unmask to
> > the PCI counterpart, and panic is any of these two methods is not
> > set in the core code (they really should be present).
> > 
> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Should I take that one?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] genirq/msi: Do not use pci_msi_[un]mask_irq as default methods Marc Zyngier <marc.zyngier@arm.com> - 2015-10-13 20:20 +0200
  Re: [PATCH] genirq/msi: Do not use pci_msi_[un]mask_irq as default  methods Jiang Liu <jiang.liu@linux.intel.com> - 2015-10-14 04:30 +0200
  Re: [PATCH] genirq/msi: Do not use pci_msi_[un]mask_irq as default  methods Thomas Gleixner <tglx@linutronix.de> - 2015-10-15 10:50 +0200
    Re: [PATCH] genirq/msi: Do not use pci_msi_[un]mask_irq as default  methods Thomas Gleixner <tglx@linutronix.de> - 2015-10-16 12:00 +0200
  [tip:irq/urgent] genirq/msi: Do not use pci_msi_[un]  mask_irq as default methods tip-bot for Marc Zyngier <tipbot@zytor.com> - 2015-10-16 14:20 +0200

csiph-web