Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1248250

Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs

From Doug Anderson <dianders@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs
Date 2015-10-16 01:40 +0200
Message-ID <qk0hP-555-1@gated-at.bofh.it> (permalink)
References <qjDbA-4sf-3@gated-at.bofh.it> <qk08a-4Qv-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


John,

On Thu, Oct 15, 2015 at 4:21 PM, John Youn <John.Youn@synopsys.com> wrote:
> Passing a NULL qtd to some of the subcases will lead to a NULL
> pointer dereference in that function or some function that it
> calls.
>
> I think you could just check the qtd after each call and bail if
> it's not ok.

I worry a little bit about ignoring an interrupt that we've already
acknowledged, but if you think that's safer I can certainly change the
patch.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs Douglas Anderson <dianders@chromium.org> - 2015-10-15 01:00 +0200
  Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous  irqs John Youn <John.Youn@synopsys.com> - 2015-10-16 01:30 +0200
    Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs Doug Anderson <dianders@chromium.org> - 2015-10-16 01:40 +0200
      Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous  irqs John Youn <John.Youn@synopsys.com> - 2015-10-16 10:00 +0200

csiph-web