Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1247069
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [GIT PULL] workqueue fixes for v4.3-rc5 |
| Date | 2015-10-14 20:50 +0200 |
| Message-ID | <qjzhD-73k-1@gated-at.bofh.it> (permalink) |
| References | <qjfLY-2wy-17@gated-at.bofh.it> <qjxfR-493-33@gated-at.bofh.it> <qjyEX-6jb-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Oct 14, 2015 at 11:03 AM, Christoph Lameter <cl@linux.com> wrote:
> On Wed, 14 Oct 2015, Linus Torvalds wrote:
>>
>> So why is this a bugfix? If cpu == WORK_CPU_UNBOUND, then things
>> _shouldn't_ care which cpu it gets run on.
>
> UNBOUND means not fixed to a processor.
That's exactly what I'm saying.
And "schedule_delayed_work()" uses WORK_CPU_UNBOUND.
YOUR code assumes that means "local CPU".
And I say that's bogus.
In this email you seem to even agree that its' bogus, but then you
wrote another email saying that the code isn't confused, because it
uses "schedule_delayed_work()" on the CPU that it wants to run the
code on.
I'm saying that mm/vmstat.c should use "schedule_delayed_work_on()".
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[GIT PULL] workqueue fixes for v4.3-rc5 Tejun Heo <tj@kernel.org> - 2015-10-14 00:00 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-14 18:40 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Tejun Heo <tj@kernel.org> - 2015-10-14 19:00 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-14 19:40 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Christoph Lameter <cl@linux.com> - 2015-10-14 20:00 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-14 20:40 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Christoph Lameter <cl@linux.com> - 2015-10-14 21:00 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-14 21:10 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Tejun Heo <tj@kernel.org> - 2015-10-14 21:10 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-14 21:20 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Tejun Heo <tj@kernel.org> - 2015-10-14 21:40 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-14 22:20 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Tejun Heo <tj@kernel.org> - 2015-10-14 22:30 +0200
Re: [PATCH] vmstat_update: ensure work remains on the same core Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-16 22:00 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Christoph Lameter <cl@linux.com> - 2015-10-14 20:10 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-14 20:50 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Christoph Lameter <cl@linux.com> - 2015-10-14 21:00 +0200
Re: [GIT PULL] workqueue fixes for v4.3-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-14 21:20 +0200
csiph-web