Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247090

Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled

Show all headers | View raw

Hello Stephen,

On 10/14/2015 08:38 PM, Stephen Boyd wrote:
> On 10/13, Javier Martinez Canillas wrote:
>> diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig
>> index 1530c9352a76..fc50b6264bed 100644
>> --- a/drivers/clk/versatile/Kconfig
>> +++ b/drivers/clk/versatile/Kconfig
>> @@ -1,6 +1,6 @@
>>  config COMMON_CLK_VERSATILE
>>  	bool "Clock driver for ARM Reference designs"
>> -	depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64
>> +	depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 || COMPILE_TEST
> 
> Have you compiled these drivers on an architecture that doesn't
> have IOMEM? Perhaps tile or um? I'm all for more build coverage,
> but it's not always as simple as just sprinkling some
> COMPILE_TEST around the Kconfigs.
>

No, I only build tested on arm32 and x86. The 0-day bot haven't reported a
build error yet and I didn't see any platform dependent code in the drivers.

But you are right that COMPILE_TEST is a little tricky, so maybe is safest
to drop this patch.

Is just that it would be nice to build as much as possible to make sure that
subystemms or kernel wide changes don't introduce regressions since that is
also tricky even when using tools like coccinelle.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-13 16:20 +0200
  Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled kbuild test robot <lkp@intel.com> - 2015-10-13 19:30 +0200
  Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Scott Branden <sbranden@broadcom.com> - 2015-10-13 19:40 +0200
  Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Stephen Boyd <sboyd@codeaurora.org> - 2015-10-14 20:40 +0200
    Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-14 21:10 +0200
      Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-14 21:40 +0200
        Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Stephen Boyd <sboyd@codeaurora.org> - 2015-10-14 23:20 +0200
          Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-16 14:20 +0200
            Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Stephen Boyd <sboyd@codeaurora.org> - 2015-10-16 21:10 +0200
      Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-15 04:10 +0200
        Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-15 09:20 +0200
          Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-15 09:30 +0200
            Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-15 09:40 +0200

csiph-web