Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

From	Lars-Peter Clausen <lars@metafoo.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] gpio/xilinx: enable for MIPS
Date	2015-10-14 18:00 +0200
Message-ID	<qjwD9-39a-41@gated-at.bofh.it> (permalink)
References	<qjtOW-7od-5@gated-at.bofh.it> <qjtOZ-7od-71@gated-at.bofh.it> <qjwD9-39a-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/14/2015 05:18 PM, Sören Brinkmann wrote:
> On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote:
>> MIPSfpga uses the axi gpio controller. Enable the driver for MIPS.
>>
>> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
>> ---
>>  drivers/gpio/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 8949b3f..58e9afd 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -508,7 +508,7 @@ config GPIO_XGENE_SB
>>  
>>  config GPIO_XILINX
>>  	tristate "Xilinx GPIO support"
>> -	depends on OF_GPIO && (PPC || MICROBLAZE || ARCH_ZYNQ || X86)
>> +	depends on OF_GPIO && (PPC || MICROBLAZE || ARCH_ZYNQ || X86 || MIPS)
> 
> Hmm, in general, this driver is hopefully generic enough that it doesn't
> have any real architecture dependencies. And I suspect, we want to
> enable this driver for ARM64 for ZynqMP soon too. Should we probably
> drop these arch dependencies completely? It seems to become quite a long list.

I've been thinking about this a while ago. This is certainly not the only
driver affected by this problem. But the thing is people always complain if
new symbols become visable in Kconfig that don't apply to their platform.

Maybe we should introduce a HAS_REPROGRAMABLE_LOGIC (or similar) feature
Kconfig symbol and let platforms which have a FPGA select it and let drivers
for FPGA peripherals depend on it.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/5] MIPS: Add Xilfpga platform Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2015-10-14 15:00 +0200
  [PATCH 1/5] dt-bindings: MIPS: Document xilfpga bindings and boot style Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2015-10-14 15:00 +0200
    Re: [PATCH 1/5] dt-bindings: MIPS: Document xilfpga bindings and  boot style James Hogan <james.hogan@imgtec.com> - 2015-10-15 09:30 +0200
  [PATCH 3/5] MIPS: dt: xilfpga: Add xilfpga device tree files. Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2015-10-14 15:00 +0200
    Re: [PATCH 3/5] MIPS: dt: xilfpga: Add xilfpga device tree files. James Hogan <james.hogan@imgtec.com> - 2015-10-15 09:50 +0200
  [PATCH 5/5] MIPS: Add xilfpga defconfig Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2015-10-14 15:00 +0200
    Re: [PATCH 5/5] MIPS: Add xilfpga defconfig James Hogan <james.hogan@imgtec.com> - 2015-10-15 10:40 +0200
  [PATCH 4/5] MIPS: xilfpga: Add mipsfpga platform code Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2015-10-14 15:00 +0200
    Re: [PATCH 4/5] MIPS: xilfpga: Add mipsfpga platform code James Hogan <james.hogan@imgtec.com> - 2015-10-15 10:20 +0200
  [PATCH 2/5] gpio/xilinx: enable for MIPS Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2015-10-14 15:00 +0200
    Re: [PATCH 2/5] gpio/xilinx: enable for MIPS Lars-Peter Clausen <lars@metafoo.de> - 2015-10-14 18:00 +0200
      Re: [PATCH 2/5] gpio/xilinx: enable for MIPS Lars-Peter Clausen <lars@metafoo.de> - 2015-10-14 19:30 +0200
        Re: [PATCH 2/5] gpio/xilinx: enable for MIPS Moritz Fischer <moritz.fischer@ettus.com> - 2015-10-14 20:30 +0200

csiph-web