Re: [PATCHv3 10/11] arm64: Add 16K page size support

From	"Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv3 10/11] arm64: Add 16K page size support
Date	2015-10-14 18:00 +0200
Message-ID	<qjwD8-39a-17@gated-at.bofh.it> (permalink)
References	<qjspQ-5qz-3@gated-at.bofh.it> <qjspS-5qz-59@gated-at.bofh.it> <qjwtr-2XK-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 14/10/15 16:40, Jeremy Linton wrote:
> On 10/14/2015 06:20 AM, Suzuki K. Poulose wrote:
>> diff --git a/arch/arm64/include/asm/page.h b/arch/arm64/include/asm/page.h
>> index da32354..736ed4c 100644
>> --- a/arch/arm64/include/asm/page.h
>> +++ b/arch/arm64/include/asm/page.h
>> @@ -24,6 +24,9 @@
>>   #ifdef CONFIG_ARM64_64K_PAGES
>>   #define PAGE_SHIFT        16
>>   #define CONT_SHIFT        5
>> +#elif defined(CONFIG_ARM64_16K_PAGES)
>> +#define PAGE_SHIFT        14
>> +#define CONT_SHIFT        9
>>   #else
>>   #define PAGE_SHIFT        12
>>   #define CONT_SHIFT        4
>
> Suzuki,
>
> Is CONT_SHIFT correct? I thought it should be 7? The ARM-ARM says that a contiguous 3rd level lookup is 128 entries.
>

Err, you are right. I tested it with 9 and I still got contiguous
mappings. May be because we anyway have 7 contiguous bits and the
kernel text is read-only. I will fix that, thanks for spotting.

Suzuki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCHv3 00/11] arm64: 16K translation granule support "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-10-14 13:30 +0200
  [PATCHv3 07/11] arm64: Kconfig: Fix help text about AArch32 support with 64K pages "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-10-14 13:30 +0200
    Re: [PATCHv3 07/11] arm64: Kconfig: Fix help text about AArch32  support with 64K pages Mark Rutland <mark.rutland@arm.com> - 2015-10-14 19:20 +0200
  [PATCHv3 10/11] arm64: Add 16K page size support "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-10-14 13:30 +0200
    Re: [PATCHv3 10/11] arm64: Add 16K page size support Jeremy Linton <jeremy.linton@arm.com> - 2015-10-14 17:50 +0200
      Re: [PATCHv3 10/11] arm64: Add 16K page size support "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-10-14 18:00 +0200
    Re: [PATCHv3 10/11] arm64: Add 16K page size support Mark Rutland <mark.rutland@arm.com> - 2015-10-15 16:10 +0200
      Re: [PATCHv3 10/11] arm64: Add 16K page size support "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-10-15 16:50 +0200
        Re: [PATCHv3 10/11] arm64: Add 16K page size support Steve Capper <steve.capper@linaro.org> - 2015-10-15 17:40 +0200
          Re: [PATCHv3 10/11] arm64: Add 16K page size support "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-10-15 17:50 +0200
  [PATCHv3 05/11] arm64: Handle 4 level page table for swapper "Suzuki K. Poulose" <suzuki.poulose@arm.com> - 2015-10-14 13:30 +0200
    Re: [PATCHv3 05/11] arm64: Handle 4 level page table for swapper Mark Rutland <mark.rutland@arm.com> - 2015-10-14 19:20 +0200

csiph-web